Repository navigation
feat: adopt DolphinDotNet launch-content SDK - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AnimalTown needs the SDK's launch-relative content resolver to load assets from the device and directory containing its standalone DOL. The engine currently pins an older SDK exactly, so consumers cannot adopt the new API without updating the engine's dependency closure.
Changes
9dcc4b6d111b109860be294820d0b14b21b8eced.LaunchContent.Mount, an explicit fallback, a validation callback and generation-boundOpenRead.Validation
git diff --checkpassed.Delivery scope
The user requested finishing the Hypercube update only, leaving the publication tag alone. This PR is ready for squash merge with all three workflows and all 16 executed checks green; the package publication job is skipped as expected for a PR.
The companion AnimalTown PR #135 remains a separate draft pending a published engine dependency. Preview publication is outside this step.