Repository navigation
Resolve content from the GameCube launch device and directory - #190
Merged
Merged
Conversation
Add an opt-in LaunchContent resolver for launcher device aliases, content directories, explicit fallbacks, and plain ISO/GCM content. Preserve borrowed mount generations, validate ambiguous DVD hints, and release acquired image dependencies in reverse order. Document the public API and validate it through 42 real-AOT executions with native storage, ISO/FST parsing, GC stress, and failure cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GameCube applications can read incoming launcher arguments, but each application currently has to translate device aliases, mount the source filesystem, preserve the installation directory, and manage fallback and cleanup itself. Swiss also uses
dvd:/for GC Loader paths and can pass a companion image instead of the executable.What changes
Dolphin.IO.LaunchContent.Mount()and an explicit-path overload. Successful results expose the selected device, content directory, diagnostic attempts, and generation-checkedOpenRead().dvd:/hints. Preserve existing mount configurations and prevent raw GC Loader startup from disturbing a borrowed physical/ODE disc.Validation
tests/storage_mounts.pyregression suite passed, including optimized native registry cases, GameCube backend fixtures, managed AOT/GC-stress cases, legacy storage, and short-I/O cleanup.git diff --checkpassed.Hosted validation passed on
66e67e8654939ce2ce40bb1ae45e4b82047eafcb: DolphinDotNet CI, NuGet package verification, and image safety / PowerPC / sanitizer checks. All 20 executed checks passed; publishing was correctly skipped for the PR event.Runtime contract
Resolution and disposal run on the application executor with mount lifecycle changes serialized. Close streams before disposing the content handle.
GetPath()returns an ordinary namespace path; useOpenRead()when a read must stay bound to the selected mount generation.Host fixtures verify the software path; physical Swiss/adapter/firmware qualification remains separate. The API does not expose a PC folder to a directly launched Dolphin DOL.