Skip to content

Resolve content from the GameCube launch device and directory - #190

Merged
capz merged 1 commit into
mainfrom
feat/launch-content-resolver
Nov 20, 2026
Merged

capz merged 1 commit into
mainfrom
feat/launch-content-resolver

Conversation

@capz

@capz capz commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Why

GameCube applications can read incoming launcher arguments, but each application currently has to translate device aliases, mount the source filesystem, preserve the installation directory, and manage fallback and cleanup itself. Swiss also uses dvd:/ for GC Loader paths and can pass a companion image instead of the executable.

What changes

  • Add Dolphin.IO.LaunchContent.Mount() and an explicit-path overload. Successful results expose the selected device, content directory, diagnostic attempts, and generation-checked OpenRead().
  • Resolve SD2SP2, SD Gecko in either slot, and GC Loader aliases while preserving relocated directories and UTF-8 filenames. Validate native path/component/depth limits before probing.
  • Require a validator or explicit source choice for ambiguous dvd:/ hints. Preserve existing mount configurations and prevent raw GC Loader startup from disturbing a borrowed physical/ODE disc.
  • Support an explicit choice between a companion image's containing directory and the FST content of a plain ISO/GCM. Track image/source dependencies and release only acquired mount generations in reverse order.
  • Add caller-supplied, ordered fallback locations for missing or unusable launcher metadata. An authoritative source's mount/content/identity failure does not select another installation.
  • Document same-directory reads, package identity validation, fallback configuration, image handling, ownership, and Dolphin setup limitations.

Validation

  • Core and compiler Release builds passed.
  • 42 real-AOT executions passed: 21 scenarios in ordinary and forced-GC modes, with actual native file reads, portable ISO/FST parsing, aliases, path limits, identity callbacks, borrowed/stale mounts, configuration conflicts, exception rollback, and cleanup fault injection.
  • Generated GameCube bundle retains incoming argument capture.
  • Existing tests/storage_mounts.py regression suite passed, including optimized native registry cases, GameCube backend fixtures, managed AOT/GC-stress cases, legacy storage, and short-I/O cleanup.
  • CI dependency/workflow inventory checks and git diff --check passed.
  • New coverage runs in the existing storage CI suite.

Hosted validation passed on 66e67e8654939ce2ce40bb1ae45e4b82047eafcb: DolphinDotNet CI, NuGet package verification, and image safety / PowerPC / sanitizer checks. All 20 executed checks passed; publishing was correctly skipped for the PR event.

Runtime contract

Resolution and disposal run on the application executor with mount lifecycle changes serialized. Close streams before disposing the content handle. GetPath() returns an ordinary namespace path; use OpenRead() when a read must stay bound to the selected mount generation.

Host fixtures verify the software path; physical Swiss/adapter/firmware qualification remains separate. The API does not expose a PC folder to a directly launched Dolphin DOL.

Add an opt-in LaunchContent resolver for launcher device aliases, content directories, explicit fallbacks, and plain ISO/GCM content. Preserve borrowed mount generations, validate ambiguous DVD hints, and release acquired image dependencies in reverse order.

Document the public API and validate it through 42 real-AOT executions with native storage, ISO/FST parsing, GC stress, and failure cleanup.
@capz
capz merged commit 9dcc4b6 into main Nov 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant