Repository navigation
Add recoverable record containers for one memory-card save item - #187
Merged
Merged
Conversation
added 4 commits
November 16, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CardRecordStore and MemoryCard.OpenRecordStore: one browser item with independently replaceable logical records, packed small records, two sector-separated checkpoints, copy-on-write allocation protecting both checkpoints and verified data/checkpoint writes. Native block access is limited to identified DNDREC01 containers and never replaces an existing file. Browser artwork is stored once; updates avoid whole-file staging/journals.
The backing store is fixed-size and exclusively owned; callers retain the MemoryCard mount and reopen after ambiguous failures. The public backend rejects I/O after its owning mount is disposed. Capacity errors preserve prior records. Multi-record/card transactions remain application-owned. See docs/card-record-store.md.
Validation: Core and compiler builds passed (existing nullable warnings); 57,856 host record-store checks passed, including every torn-sector byte boundary for initial checkpoint, data and subsequent checkpoint writes and bounded small updates; native card adapter fixture passed with strict warnings, alignment, mutable libogc file length, metadata, identity and existing-file guards. The public MemoryCard.OpenRecordStore smoke project built and generated a native AOT bundle successfully. Fixture groups and AOT smoke are wired into the corresponding CI/test gates. Physical GameCube/Swiss/Memory Card 251 and real flash power-loss testing remain outstanding.