Repository navigation
Conversation
Code review — canonical/operator PR #2951Reviewed revision: 1. Verdict — APPROVENo blocking or non-blocking issues found. The four test edits remove a test-only mutation of the expected Pebble plan, not an assertion; the full plan comparison remains. Per the post-#2872 layer-combination behavior, the base/first layer's 2. Blocking Issues (Must Fix)None. 3. Non-Blocking Suggestions & NitpicksNone. 4. Downstream & Ecosystem ConsiderationsNo downstream compatibility or ecosystem risks identified. The patch changes neither charm runtime behavior nor framework APIs; it updates tutorial test expectations and explanatory documentation to reflect Scenario's corrected layer-combination semantics. Validation evidence and limits
|
#2872 fixed a modelling error in Scenario. When combining layers,
overridewould previously take on the overriding layer's value. After that PR (and today's release),overridetakes on the first layer's value.So we need to remove a line from the unit tests of the
k8s-2and onwards charms. We can also streamline the K8s tutorial by removing the explanation of why thek8s-1unit test needed modifying ink8s-2.