Repository navigation
Conversation
m2-farzan
requested review from
cbartz,
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
November 17, 2026 06:34
m2-farzan
marked this pull request as draft
November 17, 2026 06:35
cbartz
approved these changes
Nov 17, 2026
- Grant the permissions the called reusable workflows request. The callers of auto_update_charm_libs, comment, copilot auto_update_collections and allure_report declared none, so the runs ended in startup_failure (allure-report: 403 pushing to gh-pages). - Simplify the max_pressure check as pylint 4.1.3 R1716 requires (chained-comparison). Behaviour is unchanged. - Pin pylxd to the 2.4.2 tag instead of the moving default branch. - Bump github-runner-manager to 0.18.4.
The TICS runner (jammy, python3.10, old pip) cannot read the pyproject.toml metadata of the pylxd git checkout: pip reports "produced metadata for project name unknown" and discards the candidate, then fails with "No matching distribution found for pylxd (unavailable)". Pinning the git tag did not change that. pylxd 2.4.2 is published on PyPI as a py3-none-any wheel, which needs no metadata generation and therefore installs with any pip.
test_charm_runner and test_prometheus_metrics gave the runner VM only 20 x 30 seconds (10 minutes) to register and show online. On the CI cloud the VMs are sometimes slow: test_e2e, which waits up to 30 minutes, passed on a re-run after failing once with identical code, while the 10 minute waits failed both times. Poll up to 60 times instead.
m2-farzan
force-pushed
the
mostafa/fix-main-ci
branch
from
November 18, 2026 06:40
85b83bc to
8dfb095
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the CI failures on
mainthat a code change can fix:permissionsto the callers of four reusable workflows (matches the jenkins operator now):auto_update_libs.yaml:contents: write,pull-requests: writecomment.yaml:pull-requests: writecopilot-collections-update.yaml:contents: write,pull-requests: writeallure-reportjob inintegration_test.yaml:contents: writemax_pressurecheck inpressure_reconciler.pyas0 < self._config.max_pressure < total. The behaviour is unchanged.pylxdinbase_requirements.txtto the2.4.2tag instead of the moving default branch.github-runner-managerfrom0.18.3to0.18.4.Why we need it
startup_failureon three workflows.Auto-update charm libraries,Comment on the pull requestandAuto-Update Copilot Instructionsend instartup_failureon every run. The called reusable workflows requestcontents: writeand/orpull-requests: write, and the callers declare nopermissions.canonical/jenkins-k8s-operatorcalls the sameauto_update_charm_libs.yamlwith these permissions and it runs.allure-report403. On scheduled runs,Publish Allure reportfails withPermission to canonical/github-runner-operator.git denied to github-actions[bot]when it pushes togh-pages.R1716 chained-comparisonatgithub-runner-manager/src/github_runner_manager/manager/pressure_reconciler.py:396, which failsUnit tests for github-runner-manager / Lint and unit tests. This is what blocks PRs such as chore: configure gh-jira-sync-bot #815.TICSfails withNo matching distribution found for pylxd (unavailable)and has failed 56 of the last 60 runs, since 2026-07-06. The requirement points at the default branch ofcanonical/pylxd, which is 106 commits ahead of the latest release. Pinning to the tag removes a moving target.Not covered: the scheduled
integration-testsfail onmainbecause the runners cannot reachapi.snapcraft.io(snap install lxd,core26,core20andjuju-dbtime out) and the VMs never come online. That is a runner network problem and cannot be fixed in this repository.Not verified locally: pylint, the unit tests and tox could not be run (no package installs). The new condition was checked to be equivalent to the old one on small value pairs, and the modified workflow files parse as YAML. The permissions fix and the pylxd pin can only be confirmed by the workflows themselves. If the TICS error persists after the pin, its cause is something else.
Checklist
I added or updated the documentation (if applicable)I updateddocs/changelog.mdwith user-relevant changesI added or updated tests as needed (unit and integration)If this is a Grafana dashboard: I added a screenshot of the dashboardIf this is Terraform:terraform fmtpasses andtflintreports no errorsgithub-runner-manager/pyproject.toml.Not applicable: documentation, changelog (no user-relevant change), tests (the
pressure_reconciler.pychange is a refactor covered by the existing unit tests; the other changes are CI configuration), Grafana and Terraform.