Repository navigation
docs(release): note the .NET 8 runtime requirement for ppc64le and s390x - #281
Merged
Merged
Conversation
The ppc64le and s390x packages are built framework-dependent and need a system .NET 8 runtime, unlike the other packages. Release notes come from upstream's releaseNote.md, which the patch sync overwrites and which does not mention these architectures, so prepend a fork-owned note kept under .github/.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the changes provide the intended runtime guidance while preserving the upstream release-note content and substitutions.
No open issues 🎉
What changed in this PR
Updates release-note generation to inform ppc64le and s390x runner users that a system .NET 8 runtime is required while preserving upstream release notes and placeholder substitution.
Changes:
- Adds installation guidance for the .NET 8 runtime on Ubuntu 24.04 and 26.04.
- Prepends the canonical fork-specific note to upstream release notes.
- Keeps fork-specific documentation separate from upstream-managed files.
| File | Description |
|---|---|
| .github/workflows/release.yml | Prepends the canonical fork-specific release note while preserving upstream notes and placeholder substitution. |
| .github/release-note-canonical.md | Documents the .NET 8 runtime requirement and installation commands for ppc64le and s390x packages. |
Review effort: Lite
yanksyoon
approved these changes
Nov 13, 2026
cbartz
enabled auto-merge (squash)
November 13, 2026 07:29
cbartz
disabled auto-merge
November 13, 2026 08:21
Collaborator
Author
|
doc change only - will force merge (CI failure is independent and should be fixed in a separate PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ppc64le and s390x packages need a system .NET 8 runtime, but nothing tells users. Without it the runner never connects. It loops on
You must install .NET to run this application, which is how we hit it when testing GARM with these tarballs (cloudbase/garm#949).The patches build those two arches with
<SelfContained>false</SelfContained>; the other packages bundle .NET. Our runner images already installdotnet-runtime-8.0for them, but anyone using the tarballs directly has to find that out the hard way.This prepends a short note with the install commands to every release body:
.github/release-note-canonical.md.releaseNote.mdandREADME.mdare upstream's andpatch_update_main.ymlcopies upstream over them (cp -r upstream-runner/* .), which skips.github/.release.ymlreads that file before upstream's notes, so<RUNNER_VERSION>and the other placeholders still get substituted.Checked by rendering the
Create ReleaseNotescript locally: the note comes first with the version filled in, followed by the upstream notes unchanged.AI-generated message.