You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): group runner patch failures by incident - #277
Repeated patch-update failures currently create one GitHub issue and Jira ticket per run. Group both patch workflows into one open incident tracker, with stable runner-patch-main and runner-patch-release entries containing the latest failure links.
Reuse only an open marked tracker. If none exists, create a new incident issue; never reopen closed trackers or adopt unmarked legacy issues. Each new GitHub issue has a distinct URL for Jira tracking.
Preserve closed incidents, link new trackers to their most recent predecessor, and ignore events already recorded in earlier incidents.
Preserve investigation notes and existing labels; add missing bug/ci-failure/keep labels. Closure remains manual after recovery.
Serialize reporting with queue: max; retain targeted per-run reporting and existing source guards for ordinary Runner CI/CD failures.
Existing duplicate cleanup is a separate follow-up. This PR does not close issues or modify Jira tickets.
Validation
33 reporter tests pass, covering open-only reuse, fresh incidents, historical replay protection, later run attempts, prior-incident links, labels, pagination, source guards, ordinary CI/CD deduplication, and API errors. Independent review found no issues.
Workflow lint uses the existing narrow exception for actionlint's outdated queue schema; queue: max is documented by GitHub.
cd src && ./dev.sh test is blocked at restore by existing NU1903 errors for Microsoft.AspNetCore.WebUtilities 8.0.25 (GHSA-x33c-w48q-qrgc) in Test.csproj and Runner.Worker.csproj. No runtime or dependency files are changed.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The migration path preserves the existing bug label but fails to add the required ci-failure label to the adopted tracker, leaving its labels inconsistent with the documented plan.
This PR consolidates failures from both runner patch-update workflows into a single reusable GitHub issue while preserving per-run reporting for Runner CI/CD failures.
Changes:
Added a CommonJS reporter that creates, updates, reopens, and migrates a shared patch-failure tracker.
Replaced inline shell reporting with actions/github-script and serialized workflow runs using queue: max.
Added regression tests, a path-filtered test workflow, and design and implementation documentation.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
A moderate active issue remains because ordinary failure handling now paginates through every repository issue and pull request before identifying the workflow class, causing unnecessary API calls, latency, and rate-limit pressure.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Avoid full issue pagination for ordinary workflow deduplication
.github/scripts/report-workflow-failure.cjs:22
This full listForRepo pagination happens before the Runner CI/CD branch, so every ordinary failure now downloads every issue (and every pull request) across all pages just to check one run marker. That is a regression from the previous targeted lookup and can add many API calls, rate-limit pressure, and latency as the repository's history grows; determine the workflow class first and keep ordinary deduplication targeted, only doing the full listing for patch-tracker migration.
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
No active review issues remain, with the shared failure-reporting changes and their focused tests covering migration, recurring and stale events, labels, guards, and API errors.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because the label-repair logic has an unverified edge case that could cause GitHub to reject tracker updates when the standard bug label is missing.
force merging - CI failures are unrelated and need to be fixed in a separate PR. Force merging should be safe here as we are not touching production code in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repeated patch-update failures currently create one GitHub issue and Jira ticket per run. Group both patch workflows into one open incident tracker, with stable
runner-patch-mainandrunner-patch-releaseentries containing the latest failure links.bug/ci-failure/keeplabels. Closure remains manual after recovery.queue: max; retain targeted per-run reporting and existing source guards for ordinary Runner CI/CD failures.Existing duplicate cleanup is a separate follow-up. This PR does not close issues or modify Jira tickets.
Validation
queueschema;queue: maxis documented by GitHub.cd src && ./dev.sh testis blocked at restore by existingNU1903errors forMicrosoft.AspNetCore.WebUtilities 8.0.25(GHSA-x33c-w48q-qrgc) inTest.csprojandRunner.Worker.csproj. No runtime or dependency files are changed.AI-generated message.