Skip to content

fix(ci): move hub secret check into job env (secrets not allowed in s… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camilesing merged 1 commit into from
Sep 11, 2026
Merged

fix(ci): move hub secret check into job env (secrets not allowed in s… #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ on:
jobs:
publish:
runs-on: ubuntu-latest
env:
# 仅为让步骤 if 判断可用（secrets 上下文不允许直接出现在步骤 if 表达式中）
HUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -66,7 +69,7 @@ jobs:
- name: 计算版本与镜像 tag 列表（按已配置的镜像站生成）
id: tags
env:
HUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
# HUB_USERNAME 已由 job 级 env 注入；ALI_REGISTRY 直接读 vars
ALI_REGISTRY: ${{ vars.ALI_REGISTRY }}
run: |
if [ "$GITHUB_REF_TYPE" = "tag" ]; then
Expand Down Expand Up @@ -102,7 +105,7 @@ jobs:
echo "version=$V" >> "$GITHUB_OUTPUT"

- name: Login Docker Hub（可选项，配置了才执行）
if: secrets.DOCKERHUB_USERNAME != ''
if: env.HUB_USERNAME != ''
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
Expand Down
Loading