Repository navigation
fix(calendar): skip the row's occurrence from list card menus (#2513) - #2514
Merged
Merged
Conversation
List cards opened their menu without the row's occurrence date, so Skip fell back to the task's next occurrence. Pass the date the grid's menu already uses through both the options button and right-click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2513
List cards opened their menu without the row's occurrence date, so Skip instance fell back to the task's next occurrence. This passes the date the grid's menu already uses, through both the ⋮ button and right-click. It uses the existing
getOccurrenceDateForEventhelper, and pending rows and occurrence notes behave as before.Known limits, not changed here
scheduledpast it, even when an earlier occurrence is pending. With 10 Nov pending, skipping 17 Nov records 17 Nov but setsscheduledto 24 Nov. The 10 Nov row stays on the calendar but is no longer next. This comes from the shared skip, unskip and completion plans, so it needs its own fix. The e2e spec deliberately doesn't assertscheduled.Testing
e2e/issues/issue-2513-skip-projected-occurrence.spec.ts: covers the ⋮ button and right-click. Both failed on unfixed main, recording the pending date instead of the row's, and pass with the fix.e2e/tasknotes.spec.ts, andcheck-docs.mjs.