Skip to content

fix(calendar): skip the row's occurrence from list card menus (#2513) - #2514

Merged
callumalpass merged 1 commit into
mainfrom
fix/skip-projected-occurrence-menu
Nov 7, 2026
Merged

callumalpass merged 1 commit into
mainfrom
fix/skip-projected-occurrence-menu

Conversation

@callumalpass

Copy link
Copy Markdown
Owner

Refs #2513

List cards opened their menu without the row's occurrence date, so Skip instance fell back to the task's next occurrence. This passes the date the grid's menu already uses, through both the ⋮ button and right-click. It uses the existing getOccurrenceDateForEvent helper, and pending rows and occurrence notes behave as before.

Known limits, not changed here

  • Series date: skipping a later occurrence still moves scheduled past it, even when an earlier occurrence is pending. With 10 Nov pending, skipping 17 Nov records 17 Nov but sets scheduled to 24 Nov. The 10 Nov row stays on the calendar but is no longer next. This comes from the shared skip, unskip and completion plans, so it needs its own fix. The e2e spec deliberately doesn't assert scheduled.
  • Menu dates: the Scheduled date and Due date items still apply to the series.

Testing

  • e2e/issues/issue-2513-skip-projected-occurrence.spec.ts: covers the ⋮ button and right-click. Both failed on unfixed main, recording the pending date instead of the row's, and pass with the fix.
  • Two unit tests fail without the fix and pass with it.
  • Lint, typecheck, production build and bundle size pass.
  • Jest: two full runs passed (6,039). An earlier run had one failure that didn't recur, and I didn't capture which test it was.
  • Completing "as scheduled" from these menus now also gets the row's date, but no test covers that case.
  • Not run: full e2e/tasknotes.spec.ts, and check-docs.mjs.

List cards opened their menu without the row's occurrence date, so Skip
fell back to the task's next occurrence. Pass the date the grid's menu
already uses through both the options button and right-click.
@callumalpass
callumalpass merged commit d42a403 into main Nov 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant