Repository navigation
fix(kanban): respect manual-order sort direction - #2512
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kanban always sorted the manual-order property ascending, while the Task List and the rank writer follow the configured direction, which defaults to descending. Under a descending sort, dropping one card wrote the right ranks, but the board showed the whole column reversed.
Kanban now uses one direction-aware comparison, with missing ranks last in either direction.
Upgrade effect
No ranks are migrated and nothing is written on view load. Columns already reordered under a descending sort show their intended order once after updating. This is in the release notes.
Testing
e2e/issues/kanban-manual-order-direction.spec.tsand unit tests for both directions.build:test, focused Jest (50 tests) and native e2e (2 tests) pass.issue-2489-nlp-links.test.tsfail, and they fail the same way on the clean baseline.