Repository navigation
feat(modals): rebuild task create and edit modals - #2501
Merged
Merged
Conversation
Single form state, one guarded save path, live natural language sync, draft protection, labelled chips, compact layout and a quieter footer. Fixes double submit, duplicate tasks after a failed follow-up step, dropped NLP text, Escape after editor blur, and '1h' parsing as 1 minute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds the task create and edit modals around a shared form model and save path, and reworks their layout.
Create modal
Edit modal
Both modals
Code
src/modals/taskFormModel.tsandsrc/modals/taskModalSave.ts. Inheritance between the modals is kept.EmbeddableMarkdownEditoralways pops its scope on blur.Testing
npm test, lint and typecheck pass.e2e/task-modal.spec.ts.lingui-bundled,language-packs,docs-screenshots,release-gifs.Known gaps
feature-task-modal-filled.pngstill shows the old modal.