Repository navigation
fix(calendar): split time-entry lanes only where they overlap (#2494, #2498) - #2499
Merged
Merged
Conversation
…2498) Update @tasknotes/calendar to 0.1.6. A time entry used to squeeze every item on its day into lanes, even where nothing overlapped. Now only items that overlap keep to their side; the rest use the full column. The toolbar's previous/next buttons also draw larger chevrons. Refresh the pinned host stylesheet and its hash for the new version.
callumalpass
force-pushed
the
fix/2494-calendar-lanes
branch
from
November 3, 2026 21:12
8eb878b to
14f00d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2494 (reported by @RumiaKitinari) and #2498 (reported by @mgreen3). This doesn't auto-close either issue.
Problem
Since the 4.15 calendar rewrite, one time entry on a day split the whole day into lanes. Every event shrank to about 78% of the column and every time entry to a 22% strip, even where nothing overlapped.
Change
Updates
@tasknotes/calendarfrom 0.1.5 to 0.1.6 (callumalpass/tasknotes-calendar#5):‹›glyphs.Also in this PR:
vendor/tasknotes-calendar/calendar.cssis re-copied for 0.1.6, with the same host adaptations as before. The diff against upstream differs from 0.1.5's only in the header's version and hash.scripts/calendar-css.test.mjspins the new version and hash.e2e/issues/issue-2494-calendar-lane-width.spec.ts. It fails on 0.1.5 and passes on 0.1.6.#2498 also asks for a view option to turn the lane off. This PR doesn't add one: entries that don't overlap are already full width, and
--tnc-actual-wcan widen the strip where they do.Testing
Against the published 0.1.6 (
npm cifrom this lockfile):typecheck,lint,lint:css:distandbuildpass, and the bundle is within budget.scripts/conformance-adapter-compat.test.mjsfails locally becausedocs/spec/conformanceis missing from this worktree. It fails the same way with this PR's changes stashed.calendar-engine,calendar-settingsandcalendar-batchspecs pass (21 tests).One e2e failure is unexplained.
calendar-engine.spec.ts› "dragging and resizing a task writes back to its frontmatter" failed once in 6 full runs, in 588ms, and that error wasn't captured. It then passed alone and in 5 further full runs, including 2 straight after a fresh build. The drag assertions poll for 5s, so a misplaced drag wouldn't fail that fast, which points away from the layout change, but the cause is unconfirmed.