Repository navigation
Drop legacy @mdbase-dev/connect; open collections through the published SDK - #18
Merged
Merged
Conversation
…ed SDK The legacy @mdbase-dev/connect, connect-protocol and connect-sync packages are being retired from npm. Planner already had a working SDK path (LAB builds); make it the only path and delete the Connect one. - Depend on published @mdbase-dev/sdk 0.1.0-beta.162 and @mdbase-dev/ui 0.1.0-beta.160 instead of vendored dev tarballs; remove the connect dependency, connect-protocol devDependency and pnpm overrides. - Render SdkApp in every build. The SDK environment comes from VITE_MDBASE_ENV (lab, staging, or production when unset); deploy:dev sets it from the deployment branch, and loopback dev/e2e servers use lab. - Delete the Connect gate, App, MdbasePlannerRepository, the unused native sign-in screen/binding and popup helper, and their tests. - Delete the Connect-only pending-mutation recovery UI and the mutationsDisabled gating it drove through Planner, GanttChart, TaskInspector and TaskCreateDialog. - Keep the shared task/view mapping helpers as planner-mapping.ts. - Validate the manifest with @mdbase-dev/sdk/manifest (needs the SDK release that adds that entry). - Drop Connect URL/loopback build variables and the bundle check for them. - Delete 56 stale vendor tarballs and their artifact manifests, and the capability-v2 migration notes.
beta.163 ships @mdbase-dev/sdk/manifest. The committed manifests had been regenerated in development mode; regenerate them for production.
callumalpass
marked this pull request as ready for review
November 8, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The legacy
@mdbase-dev/connect,connect-protocolandconnect-syncpackages are being retired from npm. Planner was half-migrated: LAB builds already used the SDK entry (SdkApp), and every other build used Connect. This PR makes the SDK path the only one and deletes the Connect path.What changed
@mdbase-dev/sdk0.1.0-beta.162and@mdbase-dev/ui0.1.0-beta.160. The@mdbase-dev/connectdependency, theconnect-protocoldevDependency and thepnpm.overridesforconnect-protocol/connect-syncare removed.SdkApprenders in every build, androot.tsxand the ConnectApp/ConnectionGateare deleted. The SDK environment comes fromVITE_MDBASE_ENV:lab,staging, or production when unset. An unknown value throws.deploy:devsets it from the deployment branch.dev/dev:e2esetlab, because the SDK only allows loopback origins in LAB. The consent-popup return now always delivers through@mdbase-dev/sdk/app-grant.MdbasePlannerRepository,data/connect.ts,requireOutcome, the never-wired native sign-in screen/binding and popup helper, and their tests. Also deleted: the Connect-only pending-mutation recovery banner and themutationsDisabledgating it drove through Planner, GanttChart, TaskInspector and TaskCreateDialog. Unconfirmed writes on the SDK path are handled by the SDK ledger (rejectedWritesstays).src/data/planner-mapping.ts(moved out of the old repository file).JsonObjectbecame the SDK'sPlainValuerecords.VITE_MDBASE_CONNECT_URL/LOOPBACKvariables are removed, along withverify-build's check that the bundle contains them and themdbase-connectmanual chunk.production-smokestill checks Connect health and manifest validation.vendor/mdbase-contractsremains.docs/capability-v2-migration.mdis deleted, anddocs/new-sdk.mdis cut down to the current data-layer description.Net: about −3,860 lines outside the lockfile and vendor.
Verification (local)
pnpm install --frozen-lockfile,typecheck,lint,format:check,test:deployment: pass.pnpm test(on the remote builder): 16/17 files and 135/135 tests pass. The one failing file isscripts/planner-manifest.test.mjs, which can't import@mdbase-dev/sdk/manifestyet. With that specifier aliased to the bundledconnect-protocol/manifest(which is what the new SDK entry re-exports), it passes 3/3.pnpm build(with the manifest step run through that alias): builds, andverify-buildpasses. Vite warns that the main chunk is 851 kB, over the 560 kB limit, because the SDK UI is no longer lazy-loaded behind the LAB check.pnpm test:e2e(with that alias): 13/13 pass.