Repository navigation
feat(calendar): event links, invitation states and fresher Google events - #431
Merged
Merged
Conversation
Links: the event editor offers "Join meeting", naming the host the link leads to, and "Open in Google Calendar", limited to Google Calendar's own pages. Both open outside the app. A row shows a camera beside the title of an event with a call. States: an unanswered invitation is an outline and says "Not answered"; one answered maybe says "Maybe". A timed event marked free is lighter and says "Free". Out-of-office time is hatched; focus time is labelled. A label is left out when the title already says it. Freshness: shown events are read again when the person returns after a minute or more away and every five minutes while a calendar is in front of them. A later read that cannot reach Google leaves what is shown. Reconnect: the client tells the service's reconnect_required apart from a conflict, marks the connection, and the calendar points to Settings. A service that predates the code still reads as before. Ten new strings are authored in all ten locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the calendar service's new fields and its
reconnect_requiredcode (tasknotes-calendar-service#5). Every new field is optional here, so this works against the current production service too and can ship in either order.What changes
DESIGN.mdand the live-testing checklist are updated. Ten new strings in all ten locales.Verification
rpnpm typecheck,rpnpm lint,rpnpm i18n:check,rpnpm test(2,033 passed).Not verified against a real Google account or on native builds: mocked event tests do not prove real Google behaviour.