Repository navigation
feat(gyp-to-cmake): translate ldflags to CMake link options - #480
Merged
Merged
Conversation
This was referenced Oct 14, 2026
Contributor
Author
|
Just to clarify, I’m an individual contributor—not a bot. I’ve grown tired of being repeatedly labeled that way, so I’ve decided to focus exclusively on my own projects and will not be contributing to other projects going forward. If you have a specific request for my involvement, you’re welcome to contact me directly. |
Collaborator
Loose the em-dash mate 😉 Also, didn't you just fix this in #476? 🙈 |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kraenhansen
force-pushed
the
fix/100-ldflags
branch
from
October 31, 2026 09:15
33c963c to
e38d4fd
Compare
Collaborator
|
Picked just your changeset which was missing from your previous contribution. |
kraenhansen
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #100
How I tested this
The local pnpm runtime is newer than this repository's pinned pnpm version and stops on its ignored third-party build-script safety check. I ran the package tests and TypeScript builds directly with the installed local tools instead; all relevant checks passed.