Skip to content

feat(gyp-to-cmake): translate ldflags to CMake link options - #480

Merged
kraenhansen merged 1 commit into
callstackincubator:mainfrom
KeuqS:fix/100-ldflags
Oct 31, 2026
Merged

kraenhansen merged 1 commit into
callstackincubator:mainfrom
KeuqS:fix/100-ldflags

Conversation

@KeuqS

@KeuqS KeuqS commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add `ldflags` to the validated `binding.gyp` target shape.
  • Translate target-level `ldflags` to private CMake `target_link_options`.
  • Preserve command expansion and escaped spaces, matching the existing `cflags` behavior.
  • Add a package changeset.

Closes #100

How I tested this

  • `tsx --test packages/gyp-to-cmake/src/gyp.test.ts packages/gyp-to-cmake/src/transformer.test.ts` (23 tests passed)
  • `tsc -p packages/cli-utils/tsconfig.json`
  • `tsc -p packages/gyp-to-cmake/tsconfig.json`
  • Prettier check on all changed source and test files
  • `git diff --check`

The local pnpm runtime is newer than this repository's pinned pnpm version and stops on its ignored third-party build-script safety check. I ran the package tests and TypeScript builds directly with the installed local tools instead; all relevant checks passed.

@KeuqS

KeuqS commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Just to clarify, I’m an individual contributor—not a bot. I’ve grown tired of being repeatedly labeled that way, so I’ve decided to focus exclusively on my own projects and will not be contributing to other projects going forward. If you have a specific request for my involvement, you’re welcome to contact me directly.

@kraenhansen kraenhansen self-assigned this Oct 31, 2026
@kraenhansen

kraenhansen commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Just to clarify, I’m an individual contributor—not a bot.

Loose the em-dash mate 😉 Also, didn't you just fix this in #476? 🙈

@kraenhansen
kraenhansen changed the base branch from next to main October 31, 2026 09:14
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@kraenhansen
kraenhansen merged commit 96ce52d into callstackincubator:main Oct 31, 2026
9 checks passed
@kraenhansen

Copy link
Copy Markdown
Collaborator

Picked just your changeset which was missing from your previous contribution.

@kraenhansen kraenhansen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source for this landed on main via #476, so this PR now only carries the changeset. Thanks for the contribution, @KeuqS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve gyp-to-cmake to handle "ldflags"

2 participants