Skip to content

chore: switch to Bun workspaces - #1168

Merged
troZee merged 3 commits into
mainfrom
chore/workspaces
Oct 12, 2026
Merged

troZee merged 3 commits into
mainfrom
chore/workspaces

Conversation

@krozniata

Copy link
Copy Markdown
Member

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Package-manager compatibility and native workflow trigger gaps must be addressed.

2 open findings
What changed in this PR

Migrates the repository’s library, example app, and e2e suite to a unified Bun workspace with hoisted dependencies.

Changes:

  • Adds Bun workspaces and consolidates lockfiles.
  • Updates native and Metro paths for hoisted dependencies.
  • Simplifies bootstrap and CI installation steps.
File Description
package.json Defines workspaces and shared linking.
example/​package.json Removes duplicated tooling configuration.
example/​metro.config.js Resolves the local library through workspace linking.
example/​ios/​Podfile.lock Updates pods for hoisted dependencies.
example/​ios/​PagerViewExample.xcodeproj/​project.pbxproj Updates React Native paths.
example/​android/​settings.gradle Updates Gradle plugin paths.
example/​android/​app/​build.gradle Configures hoisted React Native tooling.
e2e/​README.md Documents root workspace installation.
e2e/​bun.lock Removes the redundant e2e lockfile.
CONTRIBUTING.md Documents unified installation.
bunfig.toml Enables hoisted linking.
bun.lock Consolidates workspace dependencies.
.github/​workflows/​main.yml Uses one root install.
.github/​workflows/​ios.yml Uses workspace-installed dependencies.
.github/​workflows/​android.yml Uses workspace-installed dependencies.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
"overrides": {
"eslint-plugin-ft-flow": "^3.0.11"
"eslint-plugin-ft-flow": "^3.0.11",
"react-native-pager-view": "link:."
Comment thread package.json
Comment on lines +23 to +25
"workspaces": [
"example",
"e2e"
@krozniata
krozniata marked this pull request as ready for review October 9, 2026 13:34
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🟢 e2e: 14 passed

All 14 tests in 10 files
Test Time
🟢 tests/basic-pager.e2e.ts · 3 passed 1m 26s
🟢 basic pager › in LTR › pages horizontally 31.9s
🟢 basic pager › in LTR › pages vertically 19.5s
🟢 basic pager › in RTL › pages horizontally with the reversed gesture 35.0s
🟢 tests/issues/issue-1083-modal-set-page.e2e.ts · 1 passed 12.7s
🟢 setPage called behind a native-stack modal lands on the requested page 12.7s
🟢 tests/issues/issue-1098-nested-pager.e2e.ts · 1 passed 11.3s
🟢 outer pager stays responsive after its page count changes around a nested pager 11.3s
🟢 tests/issues/issue-1154-page-change-focus.e2e.ts · 3 passed 37.7s
🟢 leaving a page with setPage blurs its input 11.7s
🟢 leaving a page with a swipe blurs its input 9.5s
🟢 an input focused on the new page keeps focus 16.4s
🟢 tests/material-top-bar.e2e.ts · 1 passed 9.0s
🟢 material top tabs survive a native-stack push and pop 9.0s
🟢 tests/nested-pager-view.e2e.ts · 1 passed 8.5s
🟢 nested horizontal and vertical pagers scroll independently 8.5s
🟢 tests/on-page-selected.e2e.ts · 1 passed 10.2s
🟢 onPageSelected fires an alert for every page change 10.2s
🟢 tests/scrollable-pager-view.e2e.ts · 1 passed 13.8s
🟢 pager inside a ScrollView keeps its page across vertical scrolls 13.8s
🟢 tests/smoke.e2e.ts · 1 passed 6.0s
🟢 horizontal pager pages with the panel buttons 6.0s
🟢 tests/tab-view-inside-scroll-view.e2e.ts · 1 passed 11.8s
🟢 TabView inside a ScrollView swipes tabs and scrolls the page 11.8s

e2e 0.18.0 · 3m 28s · android · run artifacts

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🟢 e2e: 13 passed

All 13 tests in 11 files
Test Time
🟢 tests/basic-pager.e2e.ts · 3 passed 2m 4s
🟢 basic pager › in LTR › pages horizontally 35.6s
🟢 basic pager › in LTR › pages vertically 29.9s
🟢 basic pager › in RTL › pages horizontally with the reversed gesture 58.3s
🟢 tests/issues/issue-1083-modal-set-page.e2e.ts · 1 passed 19.7s
🟢 setPage called behind a native-stack modal lands on the requested page 19.7s
🟢 tests/issues/issue-1096-keyboard-shrink.e2e.ts · 1 passed 33.1s
🟢 keyboard avoidance does not shrink the page under the keyboard 33.1s
🟢 tests/issues/issue-1098-nested-pager.e2e.ts · 1 passed 17.7s
🟢 outer pager stays responsive after its page count changes around a nested pager 17.7s
🟢 tests/issues/issue-1142-search-bar-inset.e2e.ts · 1 passed 18.1s
🟢 FlatList inside the pager gets the search bar safe-area insets 18.1s
🟢 tests/material-top-bar.e2e.ts · 1 passed 22.9s
🟢 material top tabs survive a native-stack push and pop 22.9s
🟢 tests/nested-pager-view.e2e.ts · 1 passed 20.6s
🟢 nested horizontal and vertical pagers scroll independently 20.6s
🟢 tests/on-page-selected.e2e.ts · 1 passed 24.3s
🟢 onPageSelected fires an alert for every page change 24.3s
🟢 tests/scrollable-pager-view.e2e.ts · 1 passed 33.0s
🟢 pager inside a ScrollView keeps its page across vertical scrolls 33.0s
🟢 tests/smoke.e2e.ts · 1 passed 14.4s
🟢 horizontal pager pages with the panel buttons 14.4s
🟢 tests/tab-view-inside-scroll-view.e2e.ts · 1 passed 24.7s
🟢 TabView inside a ScrollView swipes tabs and scrolls the page 24.7s

e2e 0.18.0 · 5m 56s · ios · run artifacts

@troZee
troZee merged commit 83be137 into main Oct 12, 2026
7 checks passed
@troZee
troZee deleted the chore/workspaces branch October 12, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants