Skip to content

refactor: move interaction handlers behind daemon facade - #2227

Open
thymikee wants to merge 1 commit into
mainfrom
codex/2178-interaction-facade
Open

refactor: move interaction handlers behind daemon facade#2227
thymikee wants to merge 1 commit into
mainfrom
codex/2178-interaction-facade

Conversation

@thymikee

@thymikee thymikee commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Closes refactor(daemon): move interaction and find routes behind the interaction facade #2178.
  • Routes find and all interaction commands through src/daemon/interaction/index.ts, preserving request-chain lazy loading and route-owner metadata.
  • Moves the 25 interaction production modules and their tests and fixtures under src/daemon/interaction/internal/.
  • Adds structural red and positive-control coverage for retired handler paths and the request-handler eager closure.

Validation

  • pnpm format:check, pnpm lint, pnpm typecheck, and pnpm build pass.
  • pnpm check:layering passes all 186 structural tests and the full guard: 1,574 sources, zero value-import cycles, and zero forbidden logical imports.
  • pnpm check:fallow --base origin/main passes with no issues in 96 changed files.
  • pnpm depgraph:test, pnpm check:di-seams, and pnpm check:production-exports pass.
  • Focused interaction suites pass: 40 files and 320 tests; native interaction contract passes 8 tests.
  • pnpm check:affected --run passed 1,450 of 1,451 tests. The sole failure is an unrelated session-open test that only fails under broad related-test concurrency while signaling another worker process; the same test passes in isolation. GitHub CI remains authoritative.

Notes

  • 96 files touched; scope remains within daemon interaction ownership plus routing and structural metadata.
  • No docs or skills changed. No device session was opened.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.56 MB 2.56 MB +1.0 kB
JS gzip 860.8 kB 861.4 kB +613 B
npm tarball 982.9 kB 983.4 kB +569 B
npm unpacked 3.40 MB 3.40 MB +1.0 kB

npm unpacked components

Component Base Current Diff
JS / dist source 2.72 MB 2.72 MB +1.0 kB
Apple runner source/project 544.4 kB 544.4 kB 0 B
Apple snapshot presentation source 33.8 kB 33.8 kB 0 B
macOS helper source 54.8 kB 54.8 kB 0 B
Android helper artifacts 0 B 0 B 0 B
Other package files 46.0 kB 46.0 kB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 32.0 ms 29.8 ms -2.2 ms
CLI --help 79.7 ms 81.5 ms +1.8 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/interaction2.js +2.0 kB +363 B
dist/src/internal/daemon.js +95 B +12 B
dist/src/session2.js +42 B +8 B
dist/src/device-claim-conflict.js -6 B -5 B
dist/src/daemon-client-lifecycle.js 0 B +2 B

Top changed packed files

Packed file Base Current Diff
dist/src/interaction-flags.js 767 B 8.4 kB +7.6 kB
dist/src/interaction.js 7.9 kB 1.8 kB -6.1 kB
dist/src/runtime-policy.js 0 B 3.7 kB +3.7 kB
dist/src/session-target-evidence.js 3.7 kB 0 B -3.7 kB
dist/src/selector-runtime.js 20.7 kB 17.5 kB -3.2 kB
dist/src/interaction2.js 30.9 kB 32.9 kB +2.0 kB
dist/src/ref-snapshot-flags.js 0 B 1.5 kB +1.5 kB
dist/src/interaction-touch-reference-frame.js 1.1 kB 0 B -1.1 kB
dist/src/runtime-transport.js 0 B 679 B +679 B
dist/src/runtime-transport-hints.js 679 B 0 B -679 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(daemon): move interaction and find routes behind the interaction facade

1 participant