refactor: move utilities to owning modules - #2225
Merged
Merged
Conversation
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. Top changed packed filesNo changed packed files. |
Member
Author
|
Reviewed exact head |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the ten utilities and four tests from
src/utilsto their exact owning modules, updating only their named importers. Keep keyboard action validation insrc/coreso the command and daemon callers share one vocabulary.Closes #2141.
Validation
AGENT_DEVICE_VITEST_MAX_WORKERS=1 pnpm vitest run src/core/__tests__/device.test.ts src/core/__tests__/interactors.test.ts src/cli/parser/__tests__/perf-args.test.ts src/commands/interaction/runtime/truncate-utf8.test.ts— 4 files, 37 tests passedpnpm check:layering— passedpnpm check:fallow --base origin/main— passedpnpm check:affected --run— format, lint, typecheck, layering, Fallow, and build passed; 451/455 related files passed, with four unrelated iOS/provider timing or host-contention failures also reproduced/controlled on cleanorigin/main