Skip to content

refactor: move utilities to owning modules - #2225

Merged
thymikee merged 1 commit into
mainfrom
refactor/issue-2141-owning-utilities
Sep 1, 2026
Merged

refactor: move utilities to owning modules#2225
thymikee merged 1 commit into
mainfrom
refactor/issue-2141-owning-utilities

Conversation

@thymikee

@thymikee thymikee commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

Move the ten utilities and four tests from src/utils to their exact owning modules, updating only their named importers. Keep keyboard action validation in src/core so the command and daemon callers share one vocabulary.

Closes #2141.

Validation

  • AGENT_DEVICE_VITEST_MAX_WORKERS=1 pnpm vitest run src/core/__tests__/device.test.ts src/core/__tests__/interactors.test.ts src/cli/parser/__tests__/perf-args.test.ts src/commands/interaction/runtime/truncate-utf8.test.ts — 4 files, 37 tests passed
  • Observed planted-red regressions for validation bounds and config precedence, then restored the implementation and passed the positive controls
  • pnpm check:layering — passed
  • pnpm check:fallow --base origin/main — passed
  • pnpm check:affected --run — format, lint, typecheck, layering, Fallow, and build passed; 451/455 related files passed, with four unrelated iOS/provider timing or host-contention failures also reproduced/controlled on clean origin/main

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.56 MB 2.56 MB 0 B
JS gzip 860.9 kB 860.9 kB 0 B
npm tarball 982.9 kB 982.9 kB 0 B
npm unpacked 3.40 MB 3.40 MB 0 B

npm unpacked components

Component Base Current Diff
JS / dist source 2.72 MB 2.72 MB 0 B
Apple runner source/project 544.4 kB 544.4 kB 0 B
Apple snapshot presentation source 33.8 kB 33.8 kB 0 B
macOS helper source 54.8 kB 54.8 kB 0 B
Android helper artifacts 0 B 0 B 0 B
Other package files 46.0 kB 46.0 kB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 28.9 ms 28.8 ms -0.1 ms
CLI --help 72.2 ms 69.7 ms -2.5 ms

Top changed chunks: no changes in the largest emitted chunks.

Top changed packed files

No changed packed files.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 1, 2026
@thymikee

thymikee commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

Reviewed exact head 9f0e202ad0cd308b530cf4da884da0ee8a488d9e against #2141 and the current owning-module boundaries. Clean code-review verdict: all ten utilities/tests are exact relocations to their owning modules, the shared keyboard vocabulary remains in core, no legacy utility imports or new layering/public-surface seams remain, and the package/JS size delta is zero. The exact-head static/integration/coverage checks reviewed are green; iOS Smoke was still running at review time, so this is ready for human review but not yet a merge-ready claim.

@thymikee
thymikee merged commit a4e6805 into main Sep 1, 2026
17 of 18 checks passed
@thymikee
thymikee deleted the refactor/issue-2141-owning-utilities branch September 1, 2026 17:45
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-01 17:46 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(core): move command parsing and validation to owning modules

1 participant