refactor(ios): route Appium snapshots through engine - #2224
Open
thymikee wants to merge 6 commits into
Open
Conversation
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks:
Top changed packed files
|
Member
Author
|
Reviewed exact head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Slice A of #2195 from the exact merged #2191 head
1826b2e68bf57fcb210c487a427bc6969d210411.legacy-derived.Bundle size
CI reports +13.8 kB unpacked. Approximately 10.1 kB is the previously unreachable acquired-engine path becoming live in the existing shared
ios-snapshot-enginechunk; the new WebDriver adapter/parser is approximately 5.2 kB, while old code shrinks by approximately 1.2 kB. The shared engine is reused with no duplicate copy. Broader centralization was rejected for this independent provider slice.Validation
Final head:
e4af7a1e5b47f80b7fedfcd057ce52d925feb52b.pnpm install --frozen-lockfile && pnpm buildpassed.hittable: truefrom geometry; the restored test is green with the facts parser preserving absent hittability.Status
Published for review. Final exact-head CI and the single authorized audit for this head are pending. No merge.
No docs or skills changed; this provider-only implementation does not change command behavior or user-facing help.