You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed exact head 88b3f9e23e9b38a4c3697ae9aa653721d95083ab against corrected #2139 and ADR 0019. Clean verdict: shared line framing, lazy HTTP/body mechanics, and constant-time comparison now live behind the private @agent-device/host-kit/transport port; runtime-hint normalization moved to core; all current importers use the owning seams; no compatibility shim, public npm surface, eager node:http/node:https value import, or command/daemon policy leakage remains. Focused regression coverage is non-vacuous, all exact-head checks including native smoke are green, and package size is net lower. Ready for human review.
Preview removed because the pull request was closed.
2026-09-01 17:45 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move line framing, lazy Node HTTP/body mechanics, and constant-time secret comparison behind the private
@agent-device/host-kit/transportport; move runtime-hint resolution into core and relocate daemon-client tests to their existing owner. Existing policy, errors, wire shape, and lazy CLI startup closure remain unchanged.Closes #2139
Validation
Focused host-kit/core/CLI, daemon/remote/auth/upload, lifecycle/runtime/Metro, layering, Fallow, typecheck, build, package, and Node integration checks pass. The staged affected run reached 2,474 passing tests; 8 unrelated interaction/provider/gesture timing tests remain host-load-sensitive at their existing 5-second budgets.