test(ios): establish snapshot convergence baselines and permanent evidence - #2204
test(ios): establish snapshot convergence baselines and permanent evidence#2204thymikee wants to merge 29 commits into
Conversation
|
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks:
Top changed packed files
|
|
Reviewed exact head
The real runner attempt correctly stopped without synthetic timings, but issue #2189 still requires completed local and proxy evidence after these fixes. This PR adds 3,961 lines across the harness; itemize the justified functional growth and record why a materially smaller design reusing existing lifecycle/command/schema owners was rejected, as required by the size-review threshold. |
|
Addressed in 4aebee2:
Validation at the exact PR head: affected checks passed, Coverage passed, and the core CI lanes are green. Native release/smoke lanes are still running; no device evidence is being claimed. |
|
Re-reviewed exact head
Current completed checks are green, with native lanes still pending, but code/evidence blockers mean no readiness label. Re-review after the ownership root, completed matrices, and size rationale change. |
|
Re-reviewed exact head The current owner-action blocker is Compatibility/Fallow: Readiness evidence is also stale/incomplete: the body is stamped at old |
|
Re-reviewed exact head BLOCKED on #2189 completion/readiness evidence: attach current-head runner-backed local and proxy raw matrices; update the stale |
|
Re-reviewed exact head The two claimed raw matrices are only local |
|
Addressed on exact publication head
The PR remains published-and-reported, not merge-ready, pending the authoritative native/device lanes and the unavailable external Claude audit. |
|
Re-reviewed exact head Still BLOCKED on #2189's baseline corpus. The local artifact contains only |
|
Updated at exact publication head
This remains published-and-reported, not merge-ready; no merge was performed. |
|
BLOCKED at exact head |
|
Resolved the two exact-head blockers identified on
|
|
Re-reviewed exact head
Exact-head CI was still running, so no readiness label. |
|
Addressed at exact head
|
…s' into codex/fix-2204-g2g * origin/codex/2189-ios-snapshot-baselines: test(size): update publish preparation contracts style(size): format package evidence test # Conflicts: # scripts/__tests__/size-report-package.test.ts
|
Reviewed and repaired the current exact head holistically.
Validation: Code review is clean and the branch is mergeable. No merge performed. |
Summary
This resolves #2189 with permanent, reproducible snapshot-convergence evidence and closes the packaging gaps found during review.
scripts/prepare-publish-assets.mjsis the single owner used by release packaging and size measurement. It prepares Apple runner source plus both Android helper components, removes stale output, and validates each APK, manifest, and checksum.scripts/**is absent from the npm tarball.955edand0aecorpora were deleted. The final71fbcorpus is the only checked-in benchmark evidence.main; stalesrc/utilslayering and mutation-registry ownership now follow the moved snapshot module instead of carrying exceptions.Closes #2189
Validation
ea79642effad21b12930ef4682e5cb9fc786ce2c.71fb2483f30d90e615e949601c836aeebbf450c5.scripts/**: zero files.pnpm buildand the clean npm size-report/install measurement passed.pnpm check:affected --runpassed all runnable checks on the repaired current-main tree. After integrating the contributor's final two test-only commits, all affected checks remained green except one unrelated 5-second host-contention timeout; that exact test passed immediately on the merged head in 2.449 seconds. The 17 directly overlapping package/workflow tests also passed.Scope and design rationale
The shared preparation owner prevents release packaging and size evidence from measuring different asset sets. The checked-in
71fbfiles are the permanent benchmark corpus; superseded corpora are removed. None of the benchmark scripts or evidence is shipped in npm, while runtime-used helper assets are built, validated, and packed.No merge was performed.