CI harness: reduced confidential-balance cheatcodes tree on 4971d40d (internal, not a submission) - #6
Open
michael-moffett wants to merge 1 commit into
Open
Conversation
…rface Rebuilt on 4971d40. Ten files: the two cheatcode RPC methods, their request/response types, the generated SDK-node kit bindings for them, and the integration tests that cover them.
Greptile SummaryThe PR adds confidential Token-2022 testing cheatcodes that derive keys from signatures and decrypt available and pending balances.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking defects identified. The new RPC methods are consistently registered, filtered, serialized, exposed through the Node SDK, and covered by focused key-derivation and confidential-balance tests.
|
| Filename | Overview |
|---|---|
| crates/core/src/rpc/surfnet_cheatcodes.rs | Registers and implements the two confidential-balance RPC methods with account ownership, key-presence, and decryption error handling. |
| crates/core/src/types.rs | Implements signature parsing, confidential key derivation, authenticated available-balance decryption, and checked pending-balance recombination. |
| crates/types/src/types.rs | Adds serialized confidential request and response contracts and extends the canonical cheatcode method manifest. |
| crates/sdk-node/surfpool-sdk/kit/types/api.ts | Adds typed Node SDK methods whose bigint and nullable response fields are handled by the existing generic transport. |
| crates/core/src/tests/integration.rs | Exercises confidential deposit and apply-pending flows across supported storage configurations while documenting the intentionally uncovered transfer path. |
Sequence Diagram
sequenceDiagram
participant Client
participant RPC as Surfnet RPC
participant Crypto as Confidential helpers
participant SVM
Client->>RPC: deriveConfidentialKeys(signatures)
RPC->>Crypto: derive keys from signatures
Crypto-->>Client: ElGamal public/secret keys and AES key
Client->>RPC: getConfidentialBalance(account, keys)
RPC->>SVM: load Token-2022 account
SVM-->>RPC: account data and slot
RPC->>Crypto: decrypt available and pending balances
Crypto-->>Client: balances and pending credit counter
Reviews (1): Last reviewed commit: "Reduce confidential-balance cheatcodes c..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal CI harness. Not a submission.
This pull request exists only to run this repository's own workflows
(
rust.yml,sdk_node.yml,benchmark.yml) against the reducedconfidential-balance-cheatcodes tree, inside CaliperForge's fork.
caliperforge:main, fast-forwarded to upstream4971d40d4b4e19bda12b30b4bb40d2ac164d4d73caliperforge:local-only/755-reduced-on-4971d40dIt is not a submission to solana-foundation/surfpool or to any other party,
and it is not intended to be reviewed. It will be left open as run evidence.