update cake6 rector config to cleanup underscore prefixes - #411
Merged
Merged
Conversation
LordSimal
commented
Sep 26, 2026
| ], | ||
| 'Console' => [ | ||
| 'Cake\Console\Helper\TableHelper' => ['_defaultConfig'], | ||
| 'Cake\Console\Helper\TreeHelper' => ['_defaultConfig'], |
Member
Author
There was a problem hiding this comment.
In a past version of rector this wasn't necessary, as a rule to rename all properties inside classes using InstanceConfigTrait was fine.
But this seems to have been removed along the way and since we don't have that property in the trait itself - just the classes using the trait - we have to declare each class separately.
Contributor
There was a problem hiding this comment.
Hm..., probably, could you point what rule you're using and if that's valid bug, report at
https://github.com/rectorphp/rector/issues
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the updated underscore prefixed properties and methods, which didn't have a rector rule yet.
Tested it with current 5.x state of cakephp/cakephp and after applying the rector it didn't find any definitions anymore.