Repository navigation
Use GPUI Kit diff component for checkout review - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the local checkout diff renderer with GPUI Kit 0.7.3's read-only
Diffcomponent. Code text is selectable, Unified keeps horizontal scrolling, and Split wraps long lines so both sources stay visible in narrow panels.Files start collapsed. Clicking the filename, change counts, or blank header space expands or collapses the file, and the chevron still toggles exactly once. Colored
+and-counts follow each filename. Refreshes preserve file expansion choices and leave unchanged content untouched; binary and empty-file notes remain visible.Update native-theme-gpui to 0.6.1 for the new icon variants and restore workspace focus when switching to an empty view so global shortcuts continue working. Update the Unreleased changelog.
Validation:
cargo clippy --workspace --locked --all-targets -- -D warnings.cargo test --workspace --locked: 138 passed, 1 ignored. Includes headless layout and click checks in both modes, refresh state preservation, and patch conversion with quoted paths and multiple hunks.cargo publish --workspace --dry-run --locked: both crates package and verify successfully; nothing published.Known upstream behavior: installing changed patch content resets scroll and selection. Unchanged refreshes preserve them.
Prepared with Codex assistance.