fix(react)!: async editable never reached the checking phase

[blove]

The live bug, found next to the hazard rather than in it

Two widened type copies were filed as latent tidy-ups. Narrowing the first exposed a user-visible defect.

SurfaceFacade.beginEdit declared edit?: { draft?: unknown; status?: "checking" | "editing" } and silently discarded status. createGridUiCore.beginEdit hard-coded status: "editing", and PretableIndexedEditingState.status did not contain "checking" at all.

So "checking" was unreachable in the shipped grid — while four places compared against it:

• use-cell-edit-controller.ts:113 asks for beginEdit(addr, { status: "checking" }) on an async editable predicate
• use-editor-field.ts's PENDING_STATUSES includes it — it drives readOnly, aria-busy, and the blur-commit gate
• BooleanCellControl.tsx:33 disables on it
• types.ts:195 types PretableEditorInput.status as PretableEditStatus

Consequence: with an async editable predicate, the editor opened fully interactive and would blur-commit a draft the grid had not yet agreed to accept, instead of rendering read-only and busy until the predicate answered.

The test that could not fail

use-cell-edit-controller.test.ts:87 — "gates begin through 'checking' for async editable" — passed throughout. It runs against the controller's own stub grid, which honours the entry status the real surface threw away. A green test over a phase the shipped grid could not enter.

That is the sixth instance of this shape found in this repo recently, and the same lesson each time: the test supplied for itself the exact step that was broken.

Reachability, checked rather than assumed

Both hazards were latent, not live, and the reasoning matters:

• editing.status — const facade = {…} at pretable-surface.tsx:2328 is not annotated SurfaceFacade<TRow>, so the consumption site reads the inferred type, which was already narrow. status: string only governed the 11 as unknown as SurfaceFacade<TRow> casts, none of which read .editing.
• hidesCollapsedRows — kind only ever holds PretableExpansionDefault values. But it decides CSV complete/omissions, so a rename would have flipped completeness on every export.

The rename mutation, which is the whole point

"expanded" → "expandedd" in csv.ts:363:

• after this PR: TS2367: This comparison appears to be unintentional because the types '"collapsed" | "expanded" | "through-depth"' and '"expandedd"' have no overlap
• before: compiles clean. Only a runtime test caught it.

For the editing hazard the obvious mutation errors in both states (the inferred type was already narrow), so a discriminating one was built inside a SurfaceFacade-typed helper: === "editting" now fails TS2367, and compiled clean before.

What changed

• New public PretableOpenEditStatus — the "editing" | "validating" | "saving" | "error" union that was spelled out in four places unnamed.
• PretableIndexedEditingState.status → PretableEditStatus; beginEdit gains status?: "checking" | "editing" (default "editing"); the facade now forwards it.
• SurfaceFacade.getSnapshot().editing.status: string → PretableEditStatus.
• hidesCollapsedRows takes Readonly<PretableExpansionState> instead of a structural copy.

Both unions spell their literals out rather than using Exclude<>: an Exclude whose second argument stops naming a member silently widens to the whole union instead of failing, and the docs guard can only pin a table to a union whose members the API report states outright. They are held together by a toEqualTypeOf pair that fails if either list drifts.

Test Plan

• Pre-fix state reported for every assertion — two runtime tests failed (data-pretable-edit-status was "editing", expected "checking"), and both @ts-expect-error directives were unused (TS2578), which is how a type assertion fails.
• Rename mutation demonstrated in both directions, output above.
• Two CSV tests separate the predicate's two clauses (default.kind !== "expanded" vs overrideCount > 0) — the existing expand-all/collapse-all pair could not tell them apart.
• 2385 tests, typecheck, typecheck:public, lint, prettier, build, api:check — all clean.

Found, not fixed

1. const facade = {…} is not annotated SurfaceFacade<TRow>, and its 11 uses go through as unknown as. The interface therefore does not check the object implementing it — which is precisely how status: string survived. Making it load-bearing is a real refactor (the concrete object carries rowModel/scrollToRow the interface omits).
2. pretable-surface.tsx:6279 asserts PretableEditorInput through as unknown as — the editor contract asserted rather than checked.
3. apps/website/.../QtyEditor.tsx:4 re-declares the status union inline. Exact rather than widened, so it can drift but not silently widen. Left outside packages/.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
pretable	Ignored		Aug 17, 2026 4:22pm