Skip to content

Android state and keymap file handling; DB50X on Android documentation - #1865

Open
evgaster wants to merge 4 commits into
c3d:stablefrom
evgaster:android-state-files
Open

evgaster wants to merge 4 commits into
c3d:stablefrom
evgaster:android-state-files

Conversation

@evgaster

Copy link
Copy Markdown

The Android handling of state an keymap files from the system menu did not use the right directories.
This PR fixes that.

There are some DB50X on Android peculiarities.
This PR adds some documentation about those.

Unfortunately the corresponding documentation did not.

Here's the document, and images, that focuses on c3d#1816.
More to follow in upcomming commits.

Signed-off-by: Ed@vanGasteren
When state or keymap files were handled, the directory was ignored.
Read actions failed, write actions went to the wrong place.

Now the initial directory of the file dialog is properly set.
The filename that the user gives, not its path, is used.
The name is used on the proper path.
That diversion is given in a message to the user.

Signed-off-by: Ed@vanGasteren.net
Add documentation about the handling of state or keymap files in Android
as fixed in a previous code commit.

Signed-off-by: Ed@vanGasteren.net
@Wiljea

Wiljea commented Oct 30, 2026

Copy link
Copy Markdown

I tried this on a Samsung S20 FE (Android 13): a debug build of c214a1b, DB50x, and read ANDROID.md. It is a clear improvement.

Works:

Save State with the proposed name, force-stop, restart: the stack comes back.
Load State, selecting the (empty) file in Download: the stack of the same name in state/ comes back.
Save State again under the same name: Android asks to replace, and the state file does not change.
After an illegal name, Save State with a valid name: the dialog no longer opens on SAVE, and the stack comes back after a restart.

Remaining:

A name without extension still becomes the state file (state/essai (1)): SAVE opens the dialog every time and, after a restart, that state is not reloaded although the file exists. A user who does not know to save again under a valid name loses the stack at each restart.

Suggestion: in ui_file_selector, append ext when the name chosen does not end with it. That would remove the cause, and the loop could no longer be entered.

What would then remain of #1856 is only the repair at start of installations already caught in the loop, whose setting holds an invalid name. I would reduce #1856 to that, on top of this PR.

Not tried: Merge State and Load keymap. The black band at the top of the stack that I saw is, I believe, the first activation issue fixed in #1844, not this PR.

If a user specifies a state file for saving state they can change the extension.
But DB50X (or DB48X) to some extend relies on the extension.

So now we enforce the DB50X provided extension and overwrite the one given by the user.

Signed-off-by: Ed@vanGasteren.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants