Skip to content

fix(tests): make allowBuilds in the js pnpm-workspace a mapping instead of list - #2081

Merged
vados-cosmonic merged 1 commit into
bytecodealliance:mainfrom
TartanLlama:sy/allow-builds-mapping
Sep 9, 2026
Merged

fix(tests): make allowBuilds in the js pnpm-workspace a mapping instead of list#2081
vados-cosmonic merged 1 commit into
bytecodealliance:mainfrom
TartanLlama:sy/allow-builds-mapping

Conversation

@TartanLlama

Copy link
Copy Markdown
Contributor

allowBuilds in test/components/js/pnpm-workspace.yaml is currently a list, but it is specified to be a mapping and the current version throws an error for me when running just build:

Error:   × load configuration
  ╰─▶ Failed to parse pnpm-workspace.yaml at jco/test/components/js/pnpm-workspace.yaml: error: line 3 column 14: unexpected event: expected mapping start
       --> <input>:3:14
        |
      1 | minimumReleaseAge: 10080
      2 | blockExoticSubdeps: true
      3 | allowBuilds: []
        |              ^ unexpected event: expected mapping start
      4 |
      5 | packages:
        |

We could probably also just remove it, whichever.

@TartanLlama TartanLlama changed the title Make allowBuilds in the js pnpm-workspace a mapping instead of list fix(tests): Make allowBuilds in the js pnpm-workspace a mapping instead of list Sep 8, 2026
vados-cosmonic
vados-cosmonic previously approved these changes Sep 8, 2026
@vados-cosmonic

vados-cosmonic commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hey this looks good to me, thanks @TartanLlama -- I'm OK leaving the object in there (not removing it completely) but it looks like CI is unhappy with your commit title... We're somewhat picky about commit titles due to the release automation, but I think you want something like:

fix(tests): make allowBuilds in the js pnpm-workspace a mapping instead of list

(oh and btw the capital Make -> make is important)

See commitlint.config.mjs for more details

@TartanLlama TartanLlama changed the title fix(tests): Make allowBuilds in the js pnpm-workspace a mapping instead of list fix(tests): make allowBuilds in the js pnpm-workspace a mapping instead of list Sep 8, 2026
Merged via the queue into bytecodealliance:main with commit 8fb990e Sep 9, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants