Add FeatureDescriptor and input/output StepCount

[heavyrubberslave]

When I wanted to upgrade to v4 of this library I realized that some information is not exposed anymore, namely a descriptor of the feature and the step count.

I needed those to give the features a proper label in the UI and to make the slider jump the right amount (min: 0, max: 100, stepCount: 25 = 5 slider positions: 0, 25, 50, 75, 100).

In v3 I access them like this:

device.messageAttributes.ScalarCmd[0].FeatureDescriptor
device.messageAttributes.ScalarCmd[0].StepCount

Is this information not accessible on purpose? If not, then I'm happy to make a PR to expose it again.

[qdot]

Oh, shit, yeah, we're missing exposure on those. They do exist, they're just not accessible. Mistake on my end.

I'll try to get that updated, but you may also want to look at https://www.npmjs.com/package/@zendrex/buttplug.js which takes a different approach to the API exposure and looks more like the last version of the library.

[heavyrubberslave]

Created the PR: #304

[heavyrubberslave]

@qdot thanks for releasing the new version 🙂

Just one issue with the inputs. I get this for my Hush:

 _events: {}
    _eventsCount: 0
    _deviceInfo: {
      "DeviceFeatures": {
        "0": {
          "FeatureDescription": "",
          "FeatureIndex": 0,
          "Output": {
            "Vibrate": {
              "Value": [
                0,
                20
              ]
            }
          }
        },
        "1": {
          "FeatureDescription": "battery Level",
          "FeatureIndex": 1,
          "Input": {
            "Battery": {
              "Command": [
                "Read"
              ],
              "Value": [
                [
                  0,
                  100
                ]
              ]
            }
          }
        }
      },
      "DeviceIndex": 2,
      "DeviceMessageTimingGap": 100,
      "DeviceName": "Lovense Hush"
    }

The problem is, that for the battery input it's a nested array with ranges. But the type definition says it's just ButtplugClientDeviceFeatureValueRange not ButtplugClientDeviceFeatureValueRange[]:

export type ButtplugClientDeviceFeatureValueRange = readonly [
    min: number,
    max: number
];
export interface ButtplugClientDeviceFeatureInput {
    readonly type: Messages.InputType;
    readonly valueRange: ButtplugClientDeviceFeatureValueRange;
    readonly commands: readonly Messages.InputCommandType[];
}

[qdot]

sigh this is why I really gotta finish out our cross client compliance testing. :(

I'll have 5.0.2 out later today.

[qdot]

Fixed in 5.0.2, which came out... 4 months later -.-