revert: update go-ora driver to v3 - #1074
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1064
This pull request downgrades the
go-oraOracle database driver dependency from version 3 to version 2 across the codebase. The most important changes are:Dependency updates:
drivers.goto usegithub.com/sijms/go-ora/v2instead ofv3.go.modtogithub.com/sijms/go-ora/v2 v2.9.0.Driver registration:
drivers_gen.goto referencego-ora/v2instead ofv3.Regressions:
NULLliteral column corrupts result parsing (regression from v2) sijms/go-ora#730