Repository navigation
Conversation
Support optional sha256 URL fragments and keep runtime behavior in the CLI. Amp-Thread-ID: https://ampcode.com/threads/T-e386451c-f404-41b8-8d80-f10d9ee76197 Co-authored-by: Amp <amp@ampcode.com>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
One blocking issue in the live smoke setup. Retiring acquisition fields also changes the public plugin configuration contract, so human approval is required.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 48111, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-6.1-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. The same approval policy applies in every repository:
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). buildsworth may approve without per-PR permission.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical pipeline paths). Human approval required; buildsworth never approves.
Restore separate fixture paths because generated step keys are derived from workflow paths. Amp-Thread-ID: https://ampcode.com/threads/T-e386451c-f404-41b8-8d80-f10d9ee76197 Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
The smoke-test key collision is fixed, and I found no new issues. Retiring source-ref and minimum-release-age changes the public plugin configuration contract, so human approval is still required.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 48114, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
Superseded by a newer Buildsworth review.
Recommend the default CLI release and keep optional pinning guidance. Move custom binary examples and acquisition details into DEVELOPMENT.md. Amp-Thread-ID: https://ampcode.com/threads/T-e386451c-f404-41b8-8d80-f10d9ee76197 Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-e386451c-f404-41b8-8d80-f10d9ee76197
Amp-Thread-ID: https://ampcode.com/threads/T-e386451c-f404-41b8-8d80-f10d9ee76197 Co-authored-by: Amp <amp@ampcode.com>
🤖
Why
Testing an alternate runtime currently makes the plugin resolve Git refs, install mise and Go, and compile three platform binaries. Even released runtimes require managing mise before launching
buildkite-gha.What
Make the plugin a downloader and launcher. Keep
version: latestor an exact GitHub release; replace source builds with a raw executable URL or platform-to-URL map:URLs optionally accept
#sha256=<64 hex digits>: missing checksums are allowed, supplied checksums are enforced before execution. Official releases retain archive checksum verification. Downloads use a private temporary directory and no persistent installer cache.Remove importer mise management, compilation,
minimum-release-age, and their test/CI machinery. Keep developer mise and generated-job runtime tools. Add jq for the existing JSON configuration, leave workflow validation to the CLI, shorten the duplicated runtime documentation, and run the candidate plugin in native macOS smokes.Rollout step 2b: switch the plugin producer. Keep this draft until additive CLI support #644 is merged and released, and example producer migration #645 is merged. Verify the old-plugin/latest-CLI and new-plugin/new-CLI paths before promotion. The CLI retains legacy consumption through this step. This plugin rejects
source-refandminimum-release-agewith migration guidance. No merge or release is triggered by this PR.Companions: CLI support and product documentation.