Skip to content

fix: skip missing agent CLIs during uploads install - #723

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
fix/install-skip-missing-mcp-clis
Aug 20, 2026
Merged

fix: skip missing agent CLIs during uploads install#723
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
fix/install-skip-missing-mcp-clis

Conversation

@zachdunn

Copy link
Copy Markdown
Member

In plain terms

uploads install used to treat a missing Claude Code CLI as a hard failure, which blocked MCP setup even when Codex or Grok were available. It now registers the hosted MCP server with each of those CLIs independently, and skips any that are not on PATH.

What it does / what it is not

  • Tries Claude Code, Codex, and Grok one by one. A missing binary is skipped (mcp: skipped), not failed.
  • If at least one CLI is present, MCP still installs there. If none are, the rest of uploads install (skills, hooks) still completes with exit 0.
  • An already-registered server is still already configured. A real mcp add error still fails that client, but the others still run.
  • Not a new auth path: Claude and Grok still get the bearer header from uploads login; Codex uses OAuth on first use, matching the plugin.
  • Cursor still has no mcp add CLI, so it is unchanged (hooks only).

How to try it

uploads install --dry-run
uploads install mcp

On a machine without claude, you should see that client skipped and Codex/Grok still registered if they are installed. With none of them on PATH, MCP reports a skip instead of mcp: failed.

Technical notes

--json now reports per-client steps (mcp:claude, mcp:codex, mcp:grok) instead of a single mcp key.

Test plan

  • pnpm --filter @buildinternet/uploads test test/install.test.ts (24 tests)
  • pnpm --filter @buildinternet/uploads test test/commands-update.test.ts
  • pnpm --filter @buildinternet/uploads typecheck
  • Confirm on a machine with only one of claude/codex/grok that the others skip and MCP still installs

uploads install mcp used to fail the whole step when claude was not on
PATH, which blocked MCP setup for Codex and Grok users. Register the
hosted server with each CLI independently, and skip any that are not
installed.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 20, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
uploads-auth 795d6a4 Commit Preview URL

Branch Preview URL
Aug 20 2026, 11:05 PM

@changeset-bot

changeset-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 795d6a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@buildinternet/uploads Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed) (1)
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 53de9a02-ce16-4f38-bdae-cefc4cbb2090

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zachdunn
Zach Dunn (zachdunn) merged commit a8b1826 into main Aug 20, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the fix/install-skip-missing-mcp-clis branch August 20, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant