Repository navigation
Conversation
The pattern of property/fail-properties_can_be_associated_to_relevant_object_types
was (-|[0-9]{2,3})\/(-|[0-9]{2,3})\/(-|[0-9]{2,3}). In XML Schema regular
expressions (SingleCharEsc) "\/" is not an escape, and "/" needs none.
libxml2 since 2.10, Java 8's Xerces, xmlschema and .NET read "\/" as "/",
but libxml2 before 2.10 and any checker that follows the grammar refuse
the pattern, and the case then reads as invalid instead of fail. Where
"\/" was accepted it meant "/", so for those engines nothing changes.
The entry in scripts.md and the .ids change together.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requirement of property/fail-properties_can_be_associated_to_relevant_object_types uses this pattern:
In XML Schema regular expressions
\/is not an escape: SingleCharEsc allows only\n \r \t \\ \| \. \? \* \+ \( \) \{ \} \- \[ \] \^, and/needs no escape. Many engines read\/as/anyway: libxml2 2.11.9 (it accepts it since 2.10, as a non-standard escape), the Xerces built into Java 8, xmlschema 4.2.0, and .NET's Regex, which the IDS-Audit-tool uses. libxml2 before 2.10 refuses the pattern ("Wrong escape sequence"), and so does any checker that follows the grammar. For those, this IDS is invalid and the case comes out as invalid instead of fail, for a reason that has nothing to do with what it tests.This pull request writes the slash plainly, in the entry in
scripts.mdand in the.ids, so the two stay the same. For engines that accepted\/nothing changes: of the file's three FireRating values,-/-/-and120/120/120match andFOOBARdoes not, so the expected result stays fail. IfcOpenShell made the same change in its ids_doc_generator.py in March 2026 (IfcOpenShell/IfcOpenShell@77f0c43).I could not run the .NET build here, so I edited the
.idsline by hand. Reading the generator, it copies the pattern text as written, so regenerating should give the same file.Prepared with the help of Claude. I have read every line and will answer the review myself.