Repository navigation
Conversation
restrictions.md and specifications.md wrote boolean values as "TRUE" and "FALSE". IDS reads booleans as xs:boolean, whose values are lowercase (DataTypes.md), and the test cases say so: attribute/invalid-booleans_must_be_specified_as_lowercase_strings_2_3 and property/invalid-booleans_must_be_specified_as_lowercase_strings_3_3 are invalid because they use "FALSE". A reader who follows the manual writes an invalid IDS. This changes the four places to "true" and "false". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user manual writes boolean values in capitals in four places:
restrictions.md: "a boolean (TRUE / FALSE)" in the introduction, and "TRUE" or "FALSE" (twice) in the Enumeration section.specifications.md: the Property row of the facet table ("LoadBearing" set to "TRUE", twice) and the first example ("Value is TRUE").Since #290 (fixed in #292), booleans follow
xs:boolean, which allows onlytrue,false,1and0(DataTypes.md), and the test cases were renamed to match: attribute/invalid-booleans_must_be_specified_as_lowercase_strings_2_3 and property/invalid-booleans_must_be_specified_as_lowercase_strings_3_3 are invalid because they writeFALSE. The manual still follows the old rule, so a reader who follows it writes an IDS that the test cases call invalid.This pull request changes the four places to "true" and "false", and says once, in the introduction of
restrictions.md, that booleans are written in lowercase.One sentence I left as it is: the Enumeration section says a boolean may be given as an enumeration, but DataTypes.md allows only a pattern on
xs:boolean(XML Schema has no enumeration facet for it either). I can correct it here or separately, as you prefer.Prepared with the help of Claude. I have read every line and will answer the review myself.