Skip to content

Don't run buf-ci push job in forks - #524

Merged
anuraaga merged 1 commit into
bufbuild:mainfrom
anuraaga:buf-ci-nofork
Aug 18, 2026
Merged

Don't run buf-ci push job in forks#524
anuraaga merged 1 commit into
bufbuild:mainfrom
anuraaga:buf-ci-nofork

Conversation

@anuraaga

@anuraaga anuraaga commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Currently this workflow always fails on a push event in the fork repo, like

https://github.com/anuraaga/protovalidate/actions/runs/32110482296

This preserves handling push events in this repo while allowing contributor forks to not go red. Note, personally it's a bit confusing the same workflow runs twice on PRs for branches in this repo - I think reworking to restricting push to main and configuring the job to format/lint/push appropriately could be cleaner but took the easy approach for now.

@anuraaga
anuraaga requested a review from emcfarlane August 18, 2026 07:33
@anuraaga
anuraaga merged commit dd77401 into bufbuild:main Aug 18, 2026
9 checks passed
@emcfarlane

Copy link
Copy Markdown
Contributor

This is odd, it shouldn't be running on forks.

@anuraaga

Copy link
Copy Markdown
Contributor Author

Since the push event doesn't specify a branch (intentionally FWICT, to check PRs against the BSR), it gets executed from the push in the fork itself (can't send a PR without pushing somewhere). So the repository check takes care of making sure it's not a fork - most repos only run on main push and have less of an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants