Repository navigation
Pull CAPTCHA, hosted launch, and database locking into shared abstractions #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bb4de6a
Require the rollout flag before personal-browser mode.
matthewnanas 661b546
Share one advisory-lock helper across database callers.
matthewnanas 8723f65
Move watch SQL onto the monitor store.
matthewnanas 691d1e6
Record CAPTCHA transitions through one callback.
matthewnanas fe596ce
Share one browser operation lock across page work.
matthewnanas 8f3b01e
Move CAPTCHA gating and hosted launch out of the browser session.
matthewnanas 26f5fd3
Fix review regressions in CAPTCHA, cancellation, and 1Password guards.
matthewnanas 8505f71
Merge the hosted-browser discard helpers and pass the CAPTCHA page in…
matthewnanas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we give each replacement browser a fresh CAPTCHA transition queue here and in
selectBrowserContext?if a CAPTCHA starts and errors between tool calls,
createBrowserContextcloses the old browser but passes its pending events into the replacement. the next snapshot succeeds on the new browser, then draining the old queue marks the taskwaiting_for_userfor a challenge in the closed browser.i reproduced this locally; the regression test passes at the merge base and fails on this PR. replacing the queue when replacing the browser also keeps late callbacks from the retired browser out of the new queue.