feat(scorers): validate model parameters - #308
Draft
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Draft
feat(scorers): validate model parameters#308Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Conversation
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-validate-model-parameters
branch
from
August 14, 2026 20:15
3c04afd to
89fac1e
Compare
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-validate-model-parameters
branch
from
August 14, 2026 21:30
89fac1e to
3639e73
Compare
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-validate-model-parameters
branch
2 times, most recently
from
August 14, 2026 23:48
3595ced to
4127abc
Compare
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-validate-model-parameters
branch
from
August 15, 2026 01:50
4127abc to
aec769b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate scorer parameters against shared and custom model capabilities
It's not very elegant because this is copying the parameter validation from the backend instead of exposing it in the backend and making a call to check it with bt. However, the backend pr isn't ready yet and this allows
bt scorers createto be functionnal in the meantime.When giving an incorrect name, there's a warning but the scorer is created:
Some parameters can be checked regardless of model:
Some parameters are model-specific: