fix(types): reference axios-retry where its augmentation is used - #8
Open
MaxAdams98 wants to merge 1 commit into
Open
MaxAdams98 wants to merge 1 commit into
MaxAdams98 wants to merge 1 commit into
Conversation
client/app.tsx passes an 'axios-retry' key in an axios request config. That key exists only through axios-retry's module augmentation, which applies where the package is referenced — and nothing referenced it, so any project typechecking this file errored on it. axios-retry is already a dependency, so this is purely the missing reference. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/core/client/app.tsx:312passes an'axios-retry'key in an axios request config:That key only exists through axios-retry's module augmentation of
AxiosRequestConfig, and an augmentation applies only where the package is referenced. Nothing referenced it, so any project that typechecks this file gets:axios-retryis already a dependency (^3.3.1), so this is purely the missing reference — no dependency change.Verified in a consumer
On a project using 0.3.15, with its own workaround removed:
The reference is in
app.tsxrather than a.d.tsso it travels with the file to consumers, and becausetypes/is generated by thetypesscript and would be overwritten.Why it is worth fixing upstream
Consumers currently each carry their own reference, or filter the line out of their typecheck. A second project I compared notes with had been reading past this error long enough that it became background noise — which is how an unrelated bug (#5) survived unnoticed in their output. Adding the reference here took them to a clean typecheck.
🤖 Generated with Claude Code