Skip to content

fix(deps): move standard-version to devDependencies - #7

Open
MaxAdams98 wants to merge 1 commit into
boycce:masterfrom
MaxAdams98:fix/standard-version-dev-dependency
Open

MaxAdams98 wants to merge 1 commit into
boycce:masterfrom
MaxAdams98:fix/standard-version-dev-dependency

Conversation

@MaxAdams98

Copy link
Copy Markdown

standard-version sits in dependencies in packages/core/package.json, so it installs into every consumer of nitro-web.

It is release tooling. Nothing in the shipped code imports it — the only references are nitro's own scripts:

"major": "npm run types && standard-version -a --release-as major && npm publish && ...",
"minor": "npm run types && standard-version -a --release-as minor && npm publish && ...",
"patch": "npm run types && standard-version -a --release-as patch && npm publish && ...",

That alone makes devDependencies the right home, but it also has a practical cost. The entry is a git dependency:

"standard-version": "github:boycce/standard-version"

so consumers installing somewhere without git or an SSH key — CI images, Heroku build dynos — fail on a package their app never runs. npm 12 blocks git dependencies by default, so this goes from a slow install to a hard one.

We currently carry an overrides entry pointing it at an HTTPS tarball purely to get a deploy through. Moving it to devDependencies removes it from the consumer install tree entirely, so no override is needed.

Placed after @typescript-eslint/eslint-plugin to keep the block alphabetical, matching dependencies.

Note this does not cover clean-terminal-webpack-plugin in packages/webpack, which has the same git-URL problem but is genuinely imported, so it needs a decision rather than a move. Raising that separately.

🤖 Generated with Claude Code

standard-version is release tooling. It is never imported by shipped code and
appears only in the major/minor/patch scripts, but sitting in dependencies it
installs into every consumer of nitro-web.

It is also a git dependency (github:boycce/standard-version), so consumers
installing without git or an SSH key — CI images, Heroku — fail on a package
their app never runs. npm 12 blocks git dependencies by default, which turns
that into a hard failure rather than a slow install.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant