fix(deps): move standard-version to devDependencies - #7
Open
MaxAdams98 wants to merge 1 commit into
Open
MaxAdams98 wants to merge 1 commit into
MaxAdams98 wants to merge 1 commit into
Conversation
standard-version is release tooling. It is never imported by shipped code and appears only in the major/minor/patch scripts, but sitting in dependencies it installs into every consumer of nitro-web. It is also a git dependency (github:boycce/standard-version), so consumers installing without git or an SSH key — CI images, Heroku — fail on a package their app never runs. npm 12 blocks git dependencies by default, which turns that into a hard failure rather than a slow install. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
standard-versionsits independenciesinpackages/core/package.json, so it installs into every consumer ofnitro-web.It is release tooling. Nothing in the shipped code imports it — the only references are nitro's own scripts:
That alone makes
devDependenciesthe right home, but it also has a practical cost. The entry is a git dependency:so consumers installing somewhere without git or an SSH key — CI images, Heroku build dynos — fail on a package their app never runs. npm 12 blocks git dependencies by default, so this goes from a slow install to a hard one.
We currently carry an
overridesentry pointing it at an HTTPS tarball purely to get a deploy through. Moving it todevDependenciesremoves it from the consumer install tree entirely, so no override is needed.Placed after
@typescript-eslint/eslint-pluginto keep the block alphabetical, matchingdependencies.Note this does not cover
clean-terminal-webpack-plugininpackages/webpack, which has the same git-URL problem but is genuinely imported, so it needs a decision rather than a move. Raising that separately.🤖 Generated with Claude Code