Repository navigation
Recompile a template edited after, or in the same second as, its cache - #93
Merged
Merged
Conversation
Filesystem::isExpired() compared the template's mtime with the cache file's ATIME, strictly. Two faults: the atime moves on every read of the cache, so a render could make the cache look newer than a template edited afterwards; and mtimes are whole seconds, so a template saved again in the second it was compiled was never compiled again. Compare with the cache's mtime and treat a tie as expired. A tie costs one extra compile, never a stale page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filesystem::isExpired() compared the template's mtime with the cache file's ATIME, strictly. Two faults: the atime moves on every read of the cache, so a render could make the cache look newer than a template edited afterwards; and mtimes are whole seconds, so a template saved again in the second it was compiled was never compiled again.
Compare with the cache's mtime and treat a tie as expired. A tie costs one extra compile, never a stale page.