Repository navigation
Harden JWT validation against signature bypass (CWE-347) - #9
Merged
Merged
Conversation
- validate() now verifies the signature (SignedWith) and time claims in addition to iss/aud/id. Previously a token forged with any key passed claim validation because the signature was never checked. - Add authenticate(): verify signature + expiry, then return the parsed token, as a safe alternative to the unverified decode()/parse(). - Middleware now enforces the configured issuer and audience. Adds a regression test asserting a forged token is rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test asserting a forged token is rejected.