Repository navigation
Fix traceback colors shared between logging handlers - #144
Open
nk-batman21 wants to merge 1 commit into
Open
nk-batman21 wants to merge 1 commit into
nk-batman21 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143.
On Python 3.13+, the colored traceback is cached on the shared
LogRecord. A later plain formatter reuses its ANSI escapes; running the plain formatter first prevents the colored formatter from coloring the traceback.Keep plain exception text on the original record for record-forwarding callers, and render each formatter's exception colors on a local copy with a fresh cache. Records that arrive with cached exception text and no
exc_inforetain that text.Tests cover both handler orders with standard,
no_colorand non-TTY formatters, plus pickled records with exception information removed. Seven new regressions fail before the fix; the two cached-text-only controls pass before and after.Validation:
black,flake8,mypyandpyenvironments pass.git diff --check, pass.