Skip to content

Keep workspace executables out of the Nushell cache - #98

Merged
gauravtiwari merged 1 commit into
mainfrom
nushell-prune-workspace-executables
Nov 14, 2026
Merged

gauravtiwari merged 1 commit into
mainfrom
nushell-prune-workspace-executables

Conversation

@gauravtiwari

Copy link
Copy Markdown
Contributor

Series 3's Windows plus lanes cached every workspace test executable, binary and debug file in target/ci, so the cache grew each step. gha-plus ran out of disk on every step from 7 to 12 (run 43537134309). BoringCache plus failed at step 7 when a debug file passed the linker's size limit (LNK1140, run 43522482334). Linux, macOS and the Windows base lanes were unaffected.

After the tests, every lane now copies nu out of target for the output check and runs overlay/prune.rb. It removes the workspace's test executables, binaries, examples, copied top-level files and their .pdb/.dSYM files from target/ci. Libraries (.rlib, .rmeta, proc-macro libraries) and dependency outputs stay, so the doctests reuse them without recompiling and the plus lanes cache them. Upstream left workspace crates out of its own cache for the same reason in #19452.

The doctests still run last because a BoringCache Cargo command publishes its cache when it ends, and the doctests need the workspace libraries. All lanes run the same commands and the same prune.

The case moves to rolling_series = 4 with the same start, so every lane restarts with empty caches. Series 3 records stay.

Validation: 218 tests / 852 assertions, catalog checks, and a local Cargo workspace where doctests ran with no recompilation after the prune and only the pruned binary rebuilt. A fresh run on this branch covers Linux, macOS and Windows.

🤖 Generated with Claude Code

Windows plus lanes cached every workspace test executable, binary and
debug file in target/ci. gha-plus ran out of disk on every step from 7
to 12 and BoringCache plus hit LNK1140 at step 7. After the tests every
lane now copies nu out for the output check and removes those files,
keeping libraries and dependency outputs for the doctests and the
cache. Series 4 restarts every lane with empty caches.

nushell/nushell#19452
https://github.com/boringcache/benchmarks/actions/runs/43537134309
https://github.com/boringcache/benchmarks/actions/runs/43522482334
@gauravtiwari
gauravtiwari merged commit ca55181 into main Nov 14, 2026
33 checks passed
@gauravtiwari
gauravtiwari deleted the nushell-prune-workspace-executables branch November 14, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant