Repository navigation
Keep workspace executables out of the Nushell cache - #98
Merged
Merged
Conversation
Windows plus lanes cached every workspace test executable, binary and debug file in target/ci. gha-plus ran out of disk on every step from 7 to 12 and BoringCache plus hit LNK1140 at step 7. After the tests every lane now copies nu out for the output check and removes those files, keeping libraries and dependency outputs for the doctests and the cache. Series 4 restarts every lane with empty caches. nushell/nushell#19452 https://github.com/boringcache/benchmarks/actions/runs/43537134309 https://github.com/boringcache/benchmarks/actions/runs/43522482334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series 3's Windows plus lanes cached every workspace test executable, binary and debug file in
target/ci, so the cache grew each step.gha-plusran out of disk on every step from 7 to 12 (run 43537134309). BoringCache plus failed at step 7 when a debug file passed the linker's size limit (LNK1140, run 43522482334). Linux, macOS and the Windows base lanes were unaffected.After the tests, every lane now copies
nuout oftargetfor the output check and runsoverlay/prune.rb. It removes the workspace's test executables, binaries, examples, copied top-level files and their.pdb/.dSYMfiles fromtarget/ci. Libraries (.rlib,.rmeta, proc-macro libraries) and dependency outputs stay, so the doctests reuse them without recompiling and the plus lanes cache them. Upstream left workspace crates out of its own cache for the same reason in #19452.The doctests still run last because a BoringCache Cargo command publishes its cache when it ends, and the doctests need the workspace libraries. All lanes run the same commands and the same prune.
The case moves to
rolling_series = 4with the same start, so every lane restarts with empty caches. Series 3 records stay.Validation: 218 tests / 852 assertions, catalog checks, and a local Cargo workspace where doctests ran with no recompilation after the prune and only the pruned binary rebuilt. A fresh run on this branch covers Linux, macOS and Windows.
🤖 Generated with Claude Code