Repository navigation
Follow Nushell's split root CI job - #97
Merged
Merged
Conversation
Upstream moved formatting and Clippy into a parallel lint job and removed the check step before Clippy. Every lane now runs the root job's build, tests and doctests. Series 3 starts at the commit that made the split. nushell/nushell#19445 nushell/nushell#19453 https://github.com/nushell/nushell/blob/396a7588af811612ebfc6de5b090d4f5674d6e51/.github/workflows/ci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Nushell changed its root CI job on November 12. #19445 removed the
cargo checkstep before Clippy, and #19453 moved formatting and Clippy into a parallel lint job. The root job now runs build, tests and doctests.Every
cargo/nushelllane now runs those three Cargo commands. The build restores the cache and the doctests save it. The rustfmt and Clippy components are no longer installed. Rust stays at 1.97.1, which matches upstream'srust-toolchain.tomlat the new start.The case moves to
rolling_series = 3and starts at396a7588af811612ebfc6de5b090d4f5674d6e51, the commit that made the split. Every lane starts from an empty cache on new scopes. Series 2 records stay, and their timings include formatting, check and Clippy, so they are not compared with series 3.#19452 changes upstream's
Swatinem/rust-cachesettings. The lanes here use the shared Cargo cache configurations, so they are unchanged.Validation: 215 tests / 846 assertions, catalog checks, and the case matrix.
🤖 Generated with Claude Code