Repository navigation
Add 16- and 32-core sample runners for Chroma and Zed - #95
Merged
Merged
Conversation
Chroma's upstream image build runs on blacksmith-16vcpu-ubuntu-2404 and Zed's release build on a Namespace 32x64 profile. The largest sample runners here were 8 cores, so a manual sample could not use the machine size upstream uses. Add blacksmith-16, namespace-16x32, namespace-32x64 and namespace-32x64-cache, and allow them on the existing sample lanes. No case's [runs] or [samples] changes, so rolling and weekly samples are unaffected; the new runners are selected with -f runner=. Runner labels: https://docs.blacksmith.sh/blacksmith-runners/overview https://namespace.so/docs/reference/github-actions/runner-configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chroma's upstream image build runs on
blacksmith-16vcpu-ubuntu-2404and Zed's release build on a Namespace 32x64 profile. The largest sample runners here were 8 cores, so a manual sample could not use the machine size upstream uses.This adds four runner entries and allows them on the existing sample lanes:
blacksmith-16blacksmith-16vcpu-ubuntu-2404blacksmith-builder,boringcache-docker-plus-readernamespace-16x32nscloud-ubuntu-24.04-amd64-16x32boringcache-cargo-plus-readernamespace-32x64nscloud-ubuntu-24.04-amd64-32x64boringcache-cargo-plus-readernamespace-32x64-cachenscloud-ubuntu-24.04-amd64-32x64-with-cache, with its own cache tagnamespace-cacheNo case's
[runs]or[samples]changes, so rolling runs and the weekly samples are unaffected. The new runners are selected with-f runner=on a manual sample.Limits
[runs]would put them in rolling. The first sample dispatch frommainis the first time the labels are exercised.Runner labels
Checks
Not run locally: the repository needs Ruby 4.0.7 and the machine this was written on has 3.3.6. The TOML parses and every lane's runner key exists in
runners.toml. The Check workflow on this pull request runs the tests,bin/bench checkandactionlint.Generated by Claude Code