Repository navigation
Pass DSpace overlay lines to awk through the environment - #93
Merged
Merged
Conversation
The prepare script passed the upstream build line to awk with -v. That line ends in a backslash, and gawk, the awk on GitHub's Ubuntu runners, drops a trailing backslash in a -v value, so the line never matched. The overlay kept the original mvn command without alwaysRunPlugins. Step 1 restored the dspace module from the build cache, skipped the installer assembly, and the Dockerfile's mv of dspace-installer failed on both runners. awk now reads both lines from ENVIRON, which no awk escape-processes, and preparation fails unless the overlay contains the extension line and the changed build line. The test prepares the recorded upstream Dockerfile with every awk on the machine.
gauravtiwari
added a commit
that referenced
this pull request
Nov 12, 2026
Both runners have two step 1 records for boringcache-docker-plus, and neither is a measurement of the lane. Run 43190333755 failed because the prepare script dropped the alwaysRunPlugins flag under gawk, fixed in #93. The re-run, 43192716311, restored every module, including the three that the failed attempt had rebuilt and saved for that commit. Step 1 of the other lanes is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSpace rolling step 1 (run 43190333755) failed in
boringcache-docker-pluson both runners. The base lanes passed.Cause
This is a harness bug in the prepare script from #92. It passed the upstream build line to
awk -v, and that line ends in a backslash. gawk, the awk on GitHub's Ubuntu runners, drops a trailing backslash in a-vvalue; mawk keeps it, which is why my local check passed:The build line never matched, so the overlay kept the original
mvncommand without-Dmaven.build.cache.alwaysRunPlugins=maven-assembly-plugin:single. The extension line has no backslash, so it was still inserted. Step 1 restored 12 modules from BoringCache, includingdspace. Maven loggedSkipping plugin execution (cached): assembly:single, thenBUILD SUCCESSat 104 s, and the Dockerfile's next command failed:Fix
awkreads both lines fromENVIRON, which no awk escape-processes.test/bench/docker_overlay_test.rbprepares the recorded upstream Dockerfile (test/bench/fixtures/dspace.Dockerfile) with every awk on the machine and checks both edits. It fails against the old script under gawk, and also checks that a changed upstream build line is refused.Checks
bin/bench check: ok.After merge
Re-run step 1 with
-f mode=rolling -f step=1. It builds only the twoboringcache-docker-plusjobs, which have no passing step-1 record.Generated by Claude Code