Repository navigation
Key Euro-Office build-state mounts on the third-party builder - #100
Merged
Merged
Conversation
Euro-Office core runs its third-party builder only while CMake's THIRD_PARTY_PREPARED is unset, and stores that flag in the build directory. A build-state mount restored from before a builder change skips the builder, so dependencies added since are never built and CMake fails with missing include and source paths. The plus lanes have failed this way since rolling step 23. The plus Dockerfiles now name the native and WASM build-state mounts after a hash of core/common.cmake and core/Common/3dParty, so a change to the builder or its dependency list starts from an empty build directory. Cache-dance lanes delete restored mount directories that the Dockerfile no longer declares after the record, so old build state is not saved again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
boringcache pluslanes ofeuro-officeandeuro-office-cachehave failed at every rolling step that reached the build since step 23 (2026-11-04). Steps 40 to 52 failed earlier, in the preparation fixed by #96. The latest runs are run 43705962401 and run 43705964466:Cause
core/common.cmakerunsCommon/3dParty/build_3rdparty.pyonly whileTHIRD_PARTY_PREPAREDis unset. After the builder succeeds, it storesTHIRD_PARTY_PREPARED TRUEinCMakeCache.txt, inside the build directory. From step 23, core moved libraries into that builder: libxml2 and zlib-ng at step 23, then libjpeg-turbo, libtiff, jbig2enc, DjVuLibre and others by 2026-11-09. The restored build directories came from step 22. CMake skipped the builder, so the libraries the new revisions expect were never built.This does not depend on the provider.
gha-plusoneuro-office-corerestored its step 21 cache for steps 23 to 39 and failed with the sameCannot find source fileerrors (run 41900851226). From step 53 it passes again, because its Actions cache entry had been evicted and the build started empty. A failed build does not save its mounts, so theboringcache pluslanes restored the same step 22 build directories at every step. Those three BoringCache mount tags were deleted on 2026-11-15 and step 57 was re-run onmain.euro-office-corepassed from an empty build directory in 2,714 s and saved its mounts (run 43733617589). Oneuro-office-cache, the WASM stage that had been failing built from an empty mount and saved it. That run was cancelled while the native core stage was still building, so it has no record (run 43733614000).Change
core/common.cmakeand every file undercore/Common/3dParty. The core stage usesid=build-cache-<key>, and the WASM stage usesid=wasm-build-cache-${CACHE_BUST}-<key>.common.cmakeholds the dependency lists passed to the builder, andCommon/3dPartyholds the builder and its recipes. A change to either starts the plus lanes from an empty build directory. Upstream'sCACHE_BUSTdoes the same for WASM when someone bumps it.start_sha, with the sameTHIRD_PARTY_PREPAREDguard.CORE_CCACHEkeep the existing edits. Base lanes build upstream unchanged.cache-dancedirectory, so a renamed mount would carry its old directory into every later save.bin/bench prune-cache-dancedeletes restored directories that the plan Dockerfile no longer declares. The phase action runs it after the record, outside the timed span, and before the post-job save, forgha-plusandghcr-bake-euro-office-plus. It deletes nothing when the Dockerfile declares no cache mounts.Against core
651145267514(the revision in the failing runs), the generated core Dockerfile differs from upstream by the twoCOPYlines,ARG CORE_CCACHE=1and the mount id. Without local caches it also drops thecore-ccacheline. The WASM file differs by the existing ccache lines and the mount id.Hashing
Common/3dPartyreads about 305 MB at core651145267514. Almost all of it is the vendoredlibvlctree, which upstream removed on 2026-11-10. Preparation runs outside the timer.Checks
bundle exec ruby -Ilib -e 'Dir["test/bench/*_test.rb"].each { require_relative it }': 222 runs, 0 failures, 3 skips.bin/bench check: ok.test/bench/euro_office_preparation_test.rb: the key changes withcommon.cmake, a recipe edit and a new recipe, and does not change with other core files. Preparation stops without the builder. The keyed ids appear in the core and WASM Dockerfiles.test/bench/phase_run_test.rb: the prune keeps declared and nested mount directories, deletes stale siblings, deletes nothing without declared mounts, and touches only cache-dance lanes.actionlintwas not run locally; the Check workflow runs it.Docker - euro-office,boringcache-docker-plusandgha-pluslanes (run 43735532749): in progress. A fresh run buildsstart_sha, whose core stage predatesCORE_CCACHE. It covers preparation on a real core checkout and the prune step, not the keyed core mount.After merge
The next rolling step of
euro-officeandeuro-office-cachestarts every plus lane's build-state mounts empty. Later steps restore them untilcommon.cmakeorCommon/3dPartychanges.The step 57 re-runs saved build-state mounts under the old names:
//build-cacheforeuro-office-coreand/wasm-build-cache-2foreuro-office-cache. No lane reads them after this change, so their BoringCache tags can be deleted once the first keyed step passes.