Skip to content

renovate: Split direct and indirect Go updates - #298

Merged
jeckersb merged 1 commit into
bootc-dev:mainfrom
HarshwardhanPatil07:renovate/go-indirect-dependency-policy
Nov 4, 2026
Merged

jeckersb merged 1 commit into
bootc-dev:mainfrom
HarshwardhanPatil07:renovate/go-indirect-dependency-policy

Conversation

@HarshwardhanPatil07

@HarshwardhanPatil07 HarshwardhanPatil07 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Renovate currently groups direct and indirect Go updates in one PR. An incompatible indirect update, such as the kube-openapi revision in bootc-operator#280, can then block otherwise compatible direct updates.

@alicefr

alicefr commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

I'm a bit reluctant to disable completely the independent go update. I think we should keep updating those until they are fixed or fix them manually (or with an AI agent). A compromise, it's to try to split the direct dependencies to the indirect ones into multiple PRs.

     {                                                                                                                         
       "matchManagers": ["gomod"],                                                                                  
       "groupName": "Go direct",                                                                                
       "constraintsFiltering": "strict",                                                       
       "postUpdateOptions": ["gomodTidy"]                                         
     },                                                                                                                        
     {                                                                                                                         
       "matchManagers": ["gomod"],                                                                                             
       "matchDepTypes": ["indirect"],                                                                                          
       "groupName": "Go indirect",                                                                                             
       "enabled": true                                                                                                         
     }

Independent indirect updates can break coupled libraries and block otherwise compatible direct updates in a shared Go PR, as seen in bootc-dev/bootc-operator#280. Keep indirect updates visible for review in a separate group while filtering Go versions and tidying module changes.

Assisted-by: AI
Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
@HarshwardhanPatil07
HarshwardhanPatil07 force-pushed the renovate/go-indirect-dependency-policy branch from fb6d4d0 to 55d82be Compare November 2, 2026 10:46
@HarshwardhanPatil07 HarshwardhanPatil07 changed the title renovate: Disable independent indirect Go updates renovate: Split direct and indirect Go updates Nov 2, 2026
@jeckersb
jeckersb requested a balanced review from Copilot November 4, 2026 15:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the Renovate configuration changes separating direct and indirect Go dependency updates.

No open issues 🎉

What changed in this PR

Separates Renovate’s direct and indirect Go dependency updates so an incompatible indirect upgrade does not block direct updates in the same grouped PR.

Changes:

  • Creates separate Go direct and Go indirect groups, keeping Go version, toolchain, and replacement updates in the direct group.
  • Adds strict constraint filtering and gomodTidy post-update processing for Go module updates.
File Description
renovate-shared-config.json Splits Go update groups and configures constraint filtering and module tidying.

Review effort: Balanced

@jeckersb
jeckersb merged commit 4992d31 into bootc-dev:main Nov 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants