Repository navigation
Enable futher tests on EKS #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0e03550
e2e: Enable more node lifecycle tests on EKS
alicefr 3b50a20
e2e: Match manifest-list digests in EKS-enabled tests
alicefr 0d4de36
make: add dependency between eks test and helm
alicefr 20607d7
e2e: Match membership node images by digest
alicefr 38c527a
e2e: Increase restart resilience rollout timeout to eight minutes
alicefr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package testutil | ||
|
|
||
| import ( | ||
| "github.com/onsi/gomega" | ||
| "github.com/onsi/gomega/types" | ||
|
|
||
| bootcv1alpha1 "github.com/bootc-dev/bootc-operator/api/v1alpha1" | ||
| "github.com/bootc-dev/bootc-operator/internal/image" | ||
| ) | ||
|
|
||
| // ImageMatchesDigest matches either the content digest or the manifest-list | ||
| // digest embedded in an ImageInfo's pullspec. | ||
| func ImageMatchesDigest(digest string) types.GomegaMatcher { | ||
| return gomega.WithTransform(func(info *bootcv1alpha1.ImageInfo) bool { | ||
| return image.InfoMatchesDigest(info, digest) | ||
| }, gomega.BeTrue()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package testutil | ||
|
|
||
| import ( | ||
| "strings" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
|
|
||
| bootcv1alpha1 "github.com/bootc-dev/bootc-operator/api/v1alpha1" | ||
| ) | ||
|
|
||
| func TestImageMatchesDigest(t *testing.T) { | ||
| contentDigest := "sha256:" + strings.Repeat("a", 64) | ||
| listDigest := "sha256:" + strings.Repeat("b", 64) | ||
| info := &bootcv1alpha1.ImageInfo{ | ||
| Image: "example.com/node@" + listDigest, | ||
| ImageDigest: contentDigest, | ||
| } | ||
|
|
||
| for _, tt := range []struct { | ||
| name string | ||
| info *bootcv1alpha1.ImageInfo | ||
| digest string | ||
| want bool | ||
| }{ | ||
| {"content digest", info, contentDigest, true}, | ||
| {"manifest-list digest", info, listDigest, true}, | ||
| {"different digest", info, "sha256:" + strings.Repeat("c", 64), false}, | ||
| {"missing image", nil, listDigest, false}, | ||
| } { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| g := NewWithT(t) | ||
| matched, err := ImageMatchesDigest(tt.digest).Match(tt.info) | ||
| g.Expect(err).NotTo(HaveOccurred()) | ||
| g.Expect(matched).To(Equal(tt.want)) | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.