Repository navigation
Consolidate the compensated arithmetic into one header - #1576
Merged
Merged
Conversation
NAThompson
changed the title
NAThompson
force-pushed
the
consolidate-eft
branch
3 times, most recently
from
October 14, 2026 04:15
10aea0d to
db014da
Compare
NAThompson
added a commit
to NAThompson/math
that referenced
this pull request
Oct 14, 2026
Collaborator
Author
|
@evanmiller : Heads up. |
Jacobi theta, Kolmogorov-Smirnov, ibeta, 2F0, laguerre, gauss_hermite and the discrete entropies share two_product, two_sum_error, difference_of_products and compensated_sum. Products whose errors are tracked now come from two_product, so contraction can't fuse them: the Kolmogorov-Smirnov pdf's worst error falls from 253 to 3.4 eps; other results are bitwise identical. The header forbids reassociation, so the compensations survive -ffast-math. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NAThompson
force-pushed
the
consolidate-eft
branch
from
October 14, 2026 05:12
db014da to
736656f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jacobi theta, Kolmogorov-Smirnov, ibeta, 2F0, laguerre, gauss_hermite and the discrete entropies share two_product, two_sum_error, difference_of_products and compensated_sum. Products whose errors are tracked now come from two_product, so contraction can't fuse them: the Kolmogorov-Smirnov pdf's worst error falls from 253 to 3.4 eps; other results are bitwise identical. The header forbids reassociation, so the compensations survive -ffast-math.
Kolmogorov-Smirnov pdf in double, error in ulps against cpp_bin_float_50 (develop left, this PR right):
🤖 Generated with Claude Code