Revert "New plugins and bugfixes" - #485
Merged
Merged
Conversation
Loup-Garou911XD
added a commit
to Loup-Garou911XD/plugin-manager
that referenced
this pull request
Sep 5, 2026
PR Apply resolved the target PR with a single "exactly one PR associated with this sha" guard whose failure path called skip(), which exits 0. A sha -> PR association is eventually consistent, so a run starting seconds after a push can see an empty list: that is what happened to PR bombsquad-community#479, where PR Apply reported success having pushed nothing. The branch merged without its generated manifest entries and broke main, forcing the revert in bombsquad-community#485. Split the guard. Zero associations now polls the API five times before giving up, and both terminal outcomes (still zero, or more than one) fail the job instead of painting it green. skip() stays reserved for states that self-heal or are none of our business. Add a metadata-fixpoint commit status as the actual merge gate. PR Check cannot be one: it generates the metadata into its own workspace and tests that tree, so it goes green on a branch whose committed manifests are still empty. A correctly applied PR is a fixpoint, so the status reports success only when both apply steps found nothing left to push. Every path that leaves fixups unapplied now leaves the status unset rather than green. Make it a required check on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fwri7UzHia9kp3tPH8GgQz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.